Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
On Aug 8, 2012, at 1:56 PM, Milan Broz wrote: > On 08/08/2012 10:46 PM, Wesley Miaw wrote: > >> I did modify veritysetup on my own so the format and verify commands will >> work with regular files on disk instead of having to mount through loop >> devices. > > Which veritysetup? In upstream (c

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Milan Broz
On 08/08/2012 10:46 PM, Wesley Miaw wrote: > On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: > I did modify veritysetup on my own so the format and verify commands will > work with regular files on disk instead of having to mount through loop > devices. Which veritysetup? In upstream (cryptsetup

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: > On 08/08/2012 08:46 PM, Mikulas Patocka wrote: > >> The problem with the patch is that it changes interface to the userspace >> tool. The userspace tool veritysetup already exists in recent cryptsetup >> package, so we can't change the interface -

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Milan Broz
On 08/08/2012 08:46 PM, Mikulas Patocka wrote: > The problem with the patch is that it changes interface to the userspace > tool. The userspace tool veritysetup already exists in recent cryptsetup > package, so we can't change the interface - you should change the patch so > that the starting d

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Mikulas Patocka
Hi The problem with the patch is that it changes interface to the userspace tool. The userspace tool veritysetup already exists in recent cryptsetup package, so we can't change the interface - you should change the patch so that the starting data block is the last argument and the argument is

[PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
From: Wesley Miaw Add data device start block index to dm-verity target parameters to support verity targets where the data does not begin at sector 0 of the block device. Also fix the hash block index computation so it takes into account data offsets. Signed-off-by: Wesley Miaw --- Documentat

Re: [PATCH] dm: verity support data device offset

2012-08-07 Thread Greg KH
On Wed, Aug 08, 2012 at 12:43:28AM +, Wesley Miaw wrote: > I needed to add support for dm-verity with data that is offset into a block > device. As part of this I found that the existing code did not compute the > correct hash block index if the data_start might be non-zero. Here's a patch >

[PATCH] dm: verity support data device offset

2012-08-07 Thread Wesley Miaw
I needed to add support for dm-verity with data that is offset into a block device. As part of this I found that the existing code did not compute the correct hash block index if the data_start might be non-zero. Here's a patch to add support for a data offset target parameter as well as a fix t