Re: [PATCH] dmaengine: dw: support for clockless platforms

2015-02-11 Thread Andy Shevchenko
On Wed, 2015-02-11 at 12:07 +, Russell King - ARM Linux wrote: > On Wed, Feb 11, 2015 at 02:02:39PM +0200, Andy Shevchenko wrote: > > On Wed, 2015-02-11 at 10:10 +0800, Viresh Kumar wrote: > > > > chip->clk = devm_clk_get(chip->dev, "hclk"); > > > > - if (IS_ERR(chip->clk)) > > >

Re: [PATCH] dmaengine: dw: support for clockless platforms

2015-02-11 Thread Russell King - ARM Linux
On Wed, Feb 11, 2015 at 02:02:39PM +0200, Andy Shevchenko wrote: > On Wed, 2015-02-11 at 10:10 +0800, Viresh Kumar wrote: > > > chip->clk = devm_clk_get(chip->dev, "hclk"); > > > - if (IS_ERR(chip->clk)) > > > - return PTR_ERR(chip->clk); > > > + if (IS_ERR(chip->c

Re: [PATCH] dmaengine: dw: support for clockless platforms

2015-02-11 Thread Andy Shevchenko
On Wed, 2015-02-11 at 10:10 +0800, Viresh Kumar wrote: > On Tue, Jan 20, 2015 at 8:57 PM, Heikki Krogerus > wrote: > > When requesting clock in the platform driver, leaving > > chip->clk value as NULL if -ENOENT is returned, and > > continue. With other errors returning failure. It makes the > > d

Re: [PATCH] dmaengine: dw: support for clockless platforms

2015-02-10 Thread Viresh Kumar
On Tue, Jan 20, 2015 at 8:57 PM, Heikki Krogerus wrote: > When requesting clock in the platform driver, leaving > chip->clk value as NULL if -ENOENT is returned, and > continue. With other errors returning failure. It makes the > driver usable on platforms that do not provide the clock. > > Signed

Re: [PATCH] dmaengine: dw: support for clockless platforms

2015-02-10 Thread Vinod Koul
On Tue, Jan 20, 2015 at 02:57:57PM +0200, Heikki Krogerus wrote: > When requesting clock in the platform driver, leaving > chip->clk value as NULL if -ENOENT is returned, and > continue. With other errors returning failure. It makes the > driver usable on platforms that do not provide the clock. Ap

Re: [PATCH] dmaengine: dw: support for clockless platforms

2015-01-20 Thread Andy Shevchenko
On Tue, 2015-01-20 at 14:57 +0200, Heikki Krogerus wrote: > When requesting clock in the platform driver, leaving > chip->clk value as NULL if -ENOENT is returned, and > continue. With other errors returning failure. It makes the > driver usable on platforms that do not provide the clock. > > Sign

[PATCH] dmaengine: dw: support for clockless platforms

2015-01-20 Thread Heikki Krogerus
When requesting clock in the platform driver, leaving chip->clk value as NULL if -ENOENT is returned, and continue. With other errors returning failure. It makes the driver usable on platforms that do not provide the clock. Signed-off-by: Heikki Krogerus --- drivers/dma/dw/platform.c | 8 ++-