Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-28 Thread Vinod Koul
On Tue, Sep 26, 2017 at 09:03:50PM +0300, Alexander Kochetkov wrote: > Hello Vinod! Thanks for review! > > > 26 сент. 2017 г., в 20:37, Vinod Koul написал(а): > > > > Tested-by please... > > In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC > defined to 1 > and with

Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-26 Thread Alexander Kochetkov
Hello Vinod! Thanks for review! > 26 сент. 2017 г., в 20:37, Vinod Koul написал(а): > > Tested-by please... In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC defined to 1 and with some trace code included. Is it OK if I provide second patch I used for testing with t

Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-26 Thread Vinod Koul
On Fri, Sep 08, 2017 at 01:00:26PM +0300, Alexander Kochetkov wrote: > Thread A calls pl330_get_desc() to get descriptor. If DMAC descriptor > pool is empty pl330_get_desc() allocates new descriptor using add_desc() > and then get newly allocated descriptor using pluck_desc(). > It is possible that

[PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-08 Thread Alexander Kochetkov
Thread A calls pl330_get_desc() to get descriptor. If DMAC descriptor pool is empty pl330_get_desc() allocates new descriptor using add_desc() and then get newly allocated descriptor using pluck_desc(). It is possible that another concurrent thread B calls pluck_desc() and catch newly allocated des