Re: [PATCH] documentation: fix firmware_sample_firmware_class to build

2008-02-20 Thread Greg KH
On Wed, Feb 20, 2008 at 12:10:36PM -0800, Randy Dunlap wrote: > Greg KH wrote: >> On Mon, Feb 18, 2008 at 04:22:16PM -0800, Randy Dunlap wrote: >>> From: Randy Dunlap <[EMAIL PROTECTED]> >>> >>> Fix firmware_sample_firmware_class module to build without error. >>> sysfs.h already has the function p

Re: [PATCH] documentation: fix firmware_sample_firmware_class to build

2008-02-20 Thread Randy Dunlap
Greg KH wrote: On Mon, Feb 18, 2008 at 04:22:16PM -0800, Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Fix firmware_sample_firmware_class module to build without error. sysfs.h already has the function prototypes and has them correctly. Documentation/firmware_class/firmware_sample

Re: [PATCH] documentation: fix firmware_sample_firmware_class to build

2008-02-19 Thread Greg KH
On Mon, Feb 18, 2008 at 04:22:16PM -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix firmware_sample_firmware_class module to build without error. > sysfs.h already has the function prototypes and has them correctly. > > Documentation/firmware_class/firmware_sample_firmw

Re: [PATCH] documentation: fix firmware_sample_firmware_class to build

2008-02-19 Thread Randy Dunlap
On Mon, 18 Feb 2008 16:51:31 -0800 (PST) David Rientjes wrote: > Change sysfs_remove_bin_file() to have a return value of void in the > !CONFIG_SYSFS case, matching the return value of the same function with > the opposite configuration. > > Also moves unnecessary ';' in empty void functions. >

Re: [PATCH] documentation: fix firmware_sample_firmware_class to build

2008-02-18 Thread David Rientjes
Change sysfs_remove_bin_file() to have a return value of void in the !CONFIG_SYSFS case, matching the return value of the same function with the opposite configuration. Also moves unnecessary ';' in empty void functions. Cc: Randy Dunlap <[EMAIL PROTECTED]> Signed-off-by: David Rientjes <[EMAIL

Re: [PATCH] documentation: fix firmware_sample_firmware_class to build

2008-02-18 Thread David Rientjes
On Mon, 18 Feb 2008, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix firmware_sample_firmware_class module to build without error. > sysfs.h already has the function prototypes and has them correctly. > > Documentation/firmware_class/firmware_sample_firmware_class.c:37: erro

[PATCH] documentation: fix firmware_sample_firmware_class to build

2008-02-18 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix firmware_sample_firmware_class module to build without error. sysfs.h already has the function prototypes and has them correctly. Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file' incl