Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-09 Thread Tomi Valkeinen
On 09/12/2020 14:08, Daniel Vetter wrote: > On Wed, Dec 9, 2020 at 1:06 PM Tomi Valkeinen wrote: >> >> On 09/12/2020 13:56, Daniel Vetter wrote: >>> On Wed, Dec 9, 2020 at 12:29 PM Tomi Valkeinen >>> wrote: On 09/12/2020 02:48, Daniel Vetter wrote: > On Tue, Dec 08, 2020 at 03:50:5

Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-09 Thread Daniel Vetter
On Wed, Dec 9, 2020 at 1:06 PM Tomi Valkeinen wrote: > > On 09/12/2020 13:56, Daniel Vetter wrote: > > On Wed, Dec 9, 2020 at 12:29 PM Tomi Valkeinen > > wrote: > >> > >> On 09/12/2020 02:48, Daniel Vetter wrote: > >>> On Tue, Dec 08, 2020 at 03:50:59PM +0800, Tian Tao wrote: > Use devm_drm

Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-09 Thread Tomi Valkeinen
On 09/12/2020 13:56, Daniel Vetter wrote: > On Wed, Dec 9, 2020 at 12:29 PM Tomi Valkeinen wrote: >> >> On 09/12/2020 02:48, Daniel Vetter wrote: >>> On Tue, Dec 08, 2020 at 03:50:59PM +0800, Tian Tao wrote: Use devm_drm_irq_install to register interrupts so that drm_irq_uninstall is not

Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-09 Thread Daniel Vetter
On Wed, Dec 9, 2020 at 12:29 PM Tomi Valkeinen wrote: > > On 09/12/2020 02:48, Daniel Vetter wrote: > > On Tue, Dec 08, 2020 at 03:50:59PM +0800, Tian Tao wrote: > >> Use devm_drm_irq_install to register interrupts so that > >> drm_irq_uninstall is not needed to be called. > >> > >> Signed-off-by:

Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-09 Thread Tomi Valkeinen
On 09/12/2020 02:48, Daniel Vetter wrote: > On Tue, Dec 08, 2020 at 03:50:59PM +0800, Tian Tao wrote: >> Use devm_drm_irq_install to register interrupts so that >> drm_irq_uninstall is not needed to be called. >> >> Signed-off-by: Tian Tao > > There's another drm_irq_install in the error path. Bu

Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-08 Thread Daniel Vetter
On Tue, Dec 08, 2020 at 03:50:59PM +0800, Tian Tao wrote: > Use devm_drm_irq_install to register interrupts so that > drm_irq_uninstall is not needed to be called. > > Signed-off-by: Tian Tao There's another drm_irq_install in the error path. But I'm not sure this is safe since you're chaning th

Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-08 Thread kernel test robot
Hi Tian, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.10-rc7 next-20201207] [cannot apply to drm/drm-next] [If your patch is appl

[PATCH] drm/tidss: Use the new api devm_drm_irq_install

2020-12-07 Thread Tian Tao
Use devm_drm_irq_install to register interrupts so that drm_irq_uninstall is not needed to be called. Signed-off-by: Tian Tao --- drivers/gpu/drm/tidss/tidss_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/ti