Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-24 Thread Vladimir Oltean
On Wed, Mar 24, 2021 at 01:20:33PM -0600, Rob Herring wrote: > In addition, "fsl,ls1088a-dspi" is not known by the Linux driver, so a > fallback is needed. This is a good point, the LS1088A went completely off of my radar, thanks for pointing it out.

Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-24 Thread Rob Herring
On Wed, Mar 24, 2021 at 12:53 PM Vladimir Oltean wrote: > > On Wed, Mar 24, 2021 at 12:14:03PM -0600, Rob Herring wrote: > > On Tue, Mar 16, 2021 at 12:15:06PM +0200, Vladimir Oltean wrote: > > > On Tue, Mar 16, 2021 at 06:08:17AM +, Kuldeep Singh wrote: > > > > Compatible entries in conjugati

Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-24 Thread Vladimir Oltean
On Wed, Mar 24, 2021 at 12:14:03PM -0600, Rob Herring wrote: > On Tue, Mar 16, 2021 at 12:15:06PM +0200, Vladimir Oltean wrote: > > On Tue, Mar 16, 2021 at 06:08:17AM +, Kuldeep Singh wrote: > > > Compatible entries in conjugation require enum and const pair. > > > For example, ls1012a.dtsi use

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-24 Thread Rob Herring
On Mon, Mar 15, 2021 at 05:45:18PM +0530, Kuldeep Singh wrote: > Convert the Freescale DSPI binding to DT schema format using json-schema. > > Signed-off-by: Kuldeep Singh > --- > Hi Rob, > This patch is checked with following commands with no warnings observed. > make distclean; make allmodconfi

Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-24 Thread Rob Herring
On Tue, Mar 16, 2021 at 12:15:06PM +0200, Vladimir Oltean wrote: > On Tue, Mar 16, 2021 at 06:08:17AM +, Kuldeep Singh wrote: > > Compatible entries in conjugation require enum and const pair. > > For example, ls1012a.dtsi uses compatible = > > "fsl,ls1012a-dspi","fsl,ls1021a-v1.0-dspi"; > > S

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-24 Thread Rob Herring
On Tue, Mar 16, 2021 at 12:00:52AM +0530, Pratyush Yadav wrote: > +Cc mtd list > > Hi, > > On 15/03/21 05:45PM, Kuldeep Singh wrote: > > Convert the Freescale DSPI binding to DT schema format using json-schema. > > > > Signed-off-by: Kuldeep Singh > > --- > > Hi Rob, > > This patch is checked w

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-24 Thread Rob Herring
On Tue, Mar 16, 2021 at 07:22:56PM +0100, Michael Walle wrote: > Am 2021-03-16 19:06, schrieb Pratyush Yadav: > > On 16/03/21 06:45PM, Michael Walle wrote: > > > Am 2021-03-15 19:30, schrieb Pratyush Yadav: > > > > > > .. > > > > > +patternProperties: > > > > > + "@[0-9a-f]+": > > > > > > Should

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-22 Thread Pratyush Yadav
On 16/03/21 12:00AM, Pratyush Yadav wrote: > +Cc mtd list > > Hi, > > On 15/03/21 05:45PM, Kuldeep Singh wrote: > > Convert the Freescale DSPI binding to DT schema format using json-schema. > > > > Signed-off-by: Kuldeep Singh > > --- > > Hi Rob, > > This patch is checked with following command

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-16 Thread Michael Walle
Am 2021-03-16 19:06, schrieb Pratyush Yadav: On 16/03/21 06:45PM, Michael Walle wrote: Am 2021-03-15 19:30, schrieb Pratyush Yadav: .. > > +patternProperties: > > + "@[0-9a-f]+": Shouldn't this be "^.*@[0-9a-f]+$"? The pattern has to match _anywhere_ in the string so both should match the f

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-16 Thread Pratyush Yadav
On 16/03/21 06:45PM, Michael Walle wrote: > Am 2021-03-15 19:30, schrieb Pratyush Yadav: > > .. > > > +patternProperties: > > > + "@[0-9a-f]+": > > Shouldn't this be "^.*@[0-9a-f]+$"? The pattern has to match _anywhere_ in the string so both should match the flash node. Your pattern is more "s

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-16 Thread Michael Walle
Am 2021-03-15 19:30, schrieb Pratyush Yadav: .. +patternProperties: + "@[0-9a-f]+": Shouldn't this be "^.*@[0-9a-f]+$"? +type: object + +properties: + fsl,spi-cs-sck-delay: +description: + Delay in nanoseconds between activating chip select and the start of +

Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-16 Thread Vladimir Oltean
On Tue, Mar 16, 2021 at 06:08:17AM +, Kuldeep Singh wrote: > Compatible entries in conjugation require enum and const pair. > For example, ls1012a.dtsi uses compatible = > "fsl,ls1012a-dspi","fsl,ls1021a-v1.0-dspi"; > Same goes for LS1028 as well. > > Therefore, can't mention the compatible e

RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-15 Thread Kuldeep Singh
[PATCH] dt-bindings: spi: Convert Freescale DSPI to json > schema > > Caution: EXT Email > > Hi Kuldeep, > > On Mon, Mar 15, 2021 at 05:45:18PM +0530, Kuldeep Singh wrote: > > Convert the Freescale DSPI binding to DT schema format using json-schema. > > > &g

RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-15 Thread Kuldeep Singh
m...@lists.infradead.org > Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json > schema > > Caution: EXT Email > > +Cc mtd list > > Hi, > > On 15/03/21 05:45PM, Kuldeep Singh wrote: > > Convert the Freescale DSPI binding to DT schema fo

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-15 Thread Vladimir Oltean
Hi Kuldeep, On Mon, Mar 15, 2021 at 05:45:18PM +0530, Kuldeep Singh wrote: > Convert the Freescale DSPI binding to DT schema format using json-schema. > > Signed-off-by: Kuldeep Singh > --- > Hi Rob, > This patch is checked with following commands with no warnings observed. > make distclean; mak

Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-15 Thread Pratyush Yadav
+Cc mtd list Hi, On 15/03/21 05:45PM, Kuldeep Singh wrote: > Convert the Freescale DSPI binding to DT schema format using json-schema. > > Signed-off-by: Kuldeep Singh > --- > Hi Rob, > This patch is checked with following commands with no warnings observed. > make distclean; make allmodconfig;

[PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

2021-03-15 Thread Kuldeep Singh
Convert the Freescale DSPI binding to DT schema format using json-schema. Signed-off-by: Kuldeep Singh --- Hi Rob, This patch is checked with following commands with no warnings observed. make distclean; make allmodconfig; make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/s