Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Andreas Dilger
On Feb 15, 2005 15:29 -0800, Mitchell Blank Jr wrote: > Stephen C. Tweedie wrote: > > If we want to fix this, let's fix the macros: for example, convert > > EXT3_HAS_COMPAT_FEATURE to be > > > > ( le32_to_cpu(EXT3_SB(sb)->s_es->s_feature_compat) & (mask) ) > > Of course that's less

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Stephen C. Tweedie
Hi, On Tue, 2005-02-15 at 23:29, Mitchell Blank Jr wrote: > Of course that's less efficient though since "mask" is probably constant.. > so now the endian conversion changed from compile-time to run-time. > > Would something like > > ( ( EXT3_SB(sb)->s_es->s_feature_compat &

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Mitchell Blank Jr
Stephen C. Tweedie wrote: > If we want to fix this, let's fix the macros: for example, convert > EXT3_HAS_COMPAT_FEATURE to be > > ( le32_to_cpu(EXT3_SB(sb)->s_es->s_feature_compat) & (mask) ) Of course that's less efficient though since "mask" is probably constant.. so now the endian

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Alexey Dobriyan
On Tuesday 15 February 2005 16:12, Stephen C. Tweedie wrote: > On Tue, 2005-02-15 at 10:46, Alexey Dobriyan wrote: > > > - if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, > > - ~EXT3_FEATURE_RO_COMPAT_SUPP))) { > > + if ((ret =

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Stephen C. Tweedie
Hi, On Tue, 2005-02-15 at 10:46, Alexey Dobriyan wrote: > - if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, > - ~EXT3_FEATURE_RO_COMPAT_SUPP))) { > + if ((ret = le32_to_cpu(EXT3_HAS_RO_COMPAT_FEATURE(sb, > +

[PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- fs/ext3/resize.c| 20 ++-- fs/ext3/super.c |8 include/linux/ext3_fs.h |2 +- 3 files changed, 15 insertions(+), 15 deletions(-) Index: linux-warnings/include/linux/ext3_fs.h

[PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- fs/ext3/resize.c| 20 ++-- fs/ext3/super.c |8 include/linux/ext3_fs.h |2 +- 3 files changed, 15 insertions(+), 15 deletions(-) Index: linux-warnings/include/linux/ext3_fs.h

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Stephen C. Tweedie
Hi, On Tue, 2005-02-15 at 10:46, Alexey Dobriyan wrote: - if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, - ~EXT3_FEATURE_RO_COMPAT_SUPP))) { + if ((ret = le32_to_cpu(EXT3_HAS_RO_COMPAT_FEATURE(sb, +

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Alexey Dobriyan
On Tuesday 15 February 2005 16:12, Stephen C. Tweedie wrote: On Tue, 2005-02-15 at 10:46, Alexey Dobriyan wrote: - if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, - ~EXT3_FEATURE_RO_COMPAT_SUPP))) { + if ((ret =

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Mitchell Blank Jr
Stephen C. Tweedie wrote: If we want to fix this, let's fix the macros: for example, convert EXT3_HAS_COMPAT_FEATURE to be ( le32_to_cpu(EXT3_SB(sb)-s_es-s_feature_compat) (mask) ) Of course that's less efficient though since mask is probably constant.. so now the endian conversion

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Stephen C. Tweedie
Hi, On Tue, 2005-02-15 at 23:29, Mitchell Blank Jr wrote: Of course that's less efficient though since mask is probably constant.. so now the endian conversion changed from compile-time to run-time. Would something like ( ( EXT3_SB(sb)-s_es-s_feature_compat cpu_to_le32(mask) ) !=

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Andreas Dilger
On Feb 15, 2005 15:29 -0800, Mitchell Blank Jr wrote: Stephen C. Tweedie wrote: If we want to fix this, let's fix the macros: for example, convert EXT3_HAS_COMPAT_FEATURE to be ( le32_to_cpu(EXT3_SB(sb)-s_es-s_feature_compat) (mask) ) Of course that's less efficient though since