Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

2015-08-13 Thread Chanwoo Choi
On 08/13/2015 04:14 PM, Uwe Kleine-König wrote: > Hello, > > On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote: >> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >> changes the prototype of devm_gpiod_get_optional() API which should include >> the falgs manda

Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

2015-08-13 Thread Roger Quadros
On 13/08/15 10:24, Chanwoo Choi wrote: > > On 08/13/2015 04:06 PM, Roger Quadros wrote: >> Hi Chanwoo, >> >> On 13/08/15 03:29, Chanwoo Choi wrote: >>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >>> changes the prototype of devm_gpiod_get_optional() API which should

Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

2015-08-13 Thread Chanwoo Choi
On 08/13/2015 04:06 PM, Roger Quadros wrote: > Hi Chanwoo, > > On 13/08/15 03:29, Chanwoo Choi wrote: >> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >> changes the prototype of devm_gpiod_get_optional() API which should include >> the falgs mandatory. > > s/falgs/f

Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

2015-08-13 Thread Uwe Kleine-König
Hello, On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote: > Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") > changes the prototype of devm_gpiod_get_optional() API which should include > the falgs mandatory. I'd write: "With commit b17d1bf16cc7 ("...") it bec

Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

2015-08-13 Thread Roger Quadros
Hi Chanwoo, On 13/08/15 03:29, Chanwoo Choi wrote: > Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") > changes the prototype of devm_gpiod_get_optional() API which should include > the falgs mandatory. s/falgs/flags > > Reported-by: Stephen Rothwell > Signed-off-by:

[PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

2015-08-12 Thread Chanwoo Choi
Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") changes the prototype of devm_gpiod_get_optional() API which should include the falgs mandatory. Reported-by: Stephen Rothwell Signed-off-by: Chanwoo Choi --- drivers/extcon/extcon-palmas.c | 3 ++- 1 file changed, 2 ins