Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-28 Thread Antonino A. Daplas
On Wed, 2007-02-28 at 16:53 +, James Simmons wrote: > > On Thu, 2007-02-22 at 00:53 +, James Simmons wrote: > > > > > +/* image data is MSB-first, fb structure is MSB-first too */ > > > > > +static inline u32 expand_color(u32 c) > > > > > +{ > > > > > + return ((c & 1) | ((c & 2) << 7)

Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-28 Thread James Simmons
> On Thu, 2007-02-22 at 00:53 +, James Simmons wrote: > > > > +/* image data is MSB-first, fb structure is MSB-first too */ > > > > +static inline u32 expand_color(u32 c) > > > > +{ > > > > + return ((c & 1) | ((c & 2) << 7) | ((c & 4) << 14) | ((c & 8) > > > > << 21)) * 0xFF; > > > > +

Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-24 Thread Antonino A. Daplas
On Fri, 2007-02-23 at 13:45 +0100, Ondrej Zajicek wrote: > On Thu, Feb 22, 2007 at 08:05:33AM +0800, Antonino A. Daplas wrote: > > On Fri, 2007-02-09 at 20:34 +0100, Ondrej Zajicek wrote: > > > This patch adds driver for S3 Trio / S3 Virge. Driver is tested > > > with most versions of S3 Trio and

Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-23 Thread Ondrej Zajicek
On Thu, Feb 22, 2007 at 08:05:33AM +0800, Antonino A. Daplas wrote: > On Fri, 2007-02-09 at 20:34 +0100, Ondrej Zajicek wrote: > > This patch adds driver for S3 Trio / S3 Virge. Driver is tested > > with most versions of S3 Trio and S3 Virge, on i386. > > It is tested both as compiled-in and modul

Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-21 Thread Antonino A. Daplas
On Thu, 2007-02-22 at 00:53 +, James Simmons wrote: > > > +/* image data is MSB-first, fb structure is MSB-first too */ > > > +static inline u32 expand_color(u32 c) > > > +{ > > > + return ((c & 1) | ((c & 2) << 7) | ((c & 4) << 14) | ((c & 8) << 21)) * > > > 0xFF; > > > +} > > > + > > > +/* s

Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-21 Thread James Simmons
> > +/* image data is MSB-first, fb structure is MSB-first too */ > > +static inline u32 expand_color(u32 c) > > +{ > > + return ((c & 1) | ((c & 2) << 7) | ((c & 4) << 14) | ((c & 8) << 21)) * > > 0xFF; > > +} > > + > > +/* s3fb_iplan_imageblit silently assumes that almost everything is 8-pixe

Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-21 Thread Antonino A. Daplas
On Fri, 2007-02-09 at 20:34 +0100, Ondrej Zajicek wrote: > This patch adds driver for S3 Trio / S3 Virge. Driver is tested > with most versions of S3 Trio and S3 Virge, on i386. > It is tested both as compiled-in and module. It is against > linux-2.6.20 . > > This is version 3. There are some min

Re: [PATCH] fbdev driver for S3 Trio/Virge, updated

2007-02-09 Thread Jiri Slaby
Ondrej Zajicek napsal(a): This patch adds driver for S3 Trio / S3 Virge. Driver is tested with most versions of S3 Trio and S3 Virge, on i386. It is tested both as compiled-in and module. It is against linux-2.6.20 . This is version 3. There are some minor modifications from version 2 (mostly co

Re: [PATCH] fbdev driver for S3 Trio/Virge

2007-02-06 Thread Jiri Slaby
Ondrej Zajicek napsal(a): On Mon, Feb 05, 2007 at 11:33:12PM +0100, Jiri Slaby wrote: Ondrej Zajicek napsal(a): +#ifdef CONFIG_MTRR +#include +#endif Why ifdef? It's ifdeffed in the header itself. But this header is only available

Re: [PATCH] fbdev driver for S3 Trio/Virge

2007-02-06 Thread Philippe De Muyter
On Mon, Feb 05, 2007 at 08:51:30PM +0100, Ondrej Zajicek wrote: > This patch adds driver for S3 Trio / S3 Virge. Driver is tested > with most versions of S3 Trio and S3 Virge, on i386. > It is tested both as compiled-in and module. It is against > linux-2.6.20 . I would like to test your patch, be

Re: [PATCH] fbdev driver for S3 Trio/Virge

2007-02-06 Thread Ondrej Zajicek
On Mon, Feb 05, 2007 at 11:33:12PM +0100, Jiri Slaby wrote: > Ondrej Zajicek napsal(a): > >This patch adds driver for S3 Trio / S3 Virge. Driver is tested > >with most versions of S3 Trio and S3 Virge, on i386. > >It is tested both as c

Re: [PATCH] fbdev driver for S3 Trio/Virge

2007-02-05 Thread Jiri Slaby
Ondrej Zajicek napsal(a): This patch adds driver for S3 Trio / S3 Virge. Driver is tested with most versions of S3 Trio and S3 Virge, on i386. It is tested both as compiled-in and module. It is against linux-2.6.20 . This is version 2. Version 1 is in -mm tree. Changes from version 1: * proper