On Wed, Apr 17, 2013 at 9:45 PM, Colin Cross wrote:
> This fixes my build issue, and doesn't introduce a new make
> headers_check warning so you can add my Tested-by: Colin Cross
>
Thanks for testing.
Linus, can you please pull this single fix from:
On Wed, Apr 17, 2013 at 2:57 AM, Miklos Szeredi wrote:
> On Tue, Apr 16, 2013 at 01:00:37PM -0700, Colin Cross wrote:
>
>> Every other uapi header includes linux/types.h to get its type
>> definitions, and fuse.h should do the same when compiling for
>> userspace targeting linux
>
> Not
On Tue, Apr 16, 2013 at 01:00:37PM -0700, Colin Cross wrote:
> Every other uapi header includes linux/types.h to get its type
> definitions, and fuse.h should do the same when compiling for
> userspace targeting linux
Not necessarily.
Here's a patch (largish but only search) that should fix all
On Tue, Apr 16, 2013 at 01:00:37PM -0700, Colin Cross wrote:
Every other uapi header includes linux/types.h to get its type
definitions, and fuse.h should do the same when compiling for
userspace targeting linux
Not necessarily.
Here's a patch (largish but only searchreplace) that should fix
On Wed, Apr 17, 2013 at 2:57 AM, Miklos Szeredi mik...@szeredi.hu wrote:
On Tue, Apr 16, 2013 at 01:00:37PM -0700, Colin Cross wrote:
Every other uapi header includes linux/types.h to get its type
definitions, and fuse.h should do the same when compiling for
userspace targeting linux
Not
On Wed, Apr 17, 2013 at 9:45 PM, Colin Cross ccr...@android.com wrote:
This fixes my build issue, and doesn't introduce a new make
headers_check warning so you can add my Tested-by: Colin Cross
ccr...@android.com
Thanks for testing.
Linus, can you please pull this single fix from:
On Tue, Apr 16, 2013 at 12:11 PM, Miklos Szeredi wrote:
> On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross wrote:
>> Dropping __linux__ causes a make headers_check warning, which the
>> kbuild test robot reported this morning:
>> usr/include/linux/fuse.h:99: found __[us]{8,16,32,64} type without
>>
On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross wrote:
> Dropping __linux__ causes a make headers_check warning, which the
> kbuild test robot reported this morning:
> usr/include/linux/fuse.h:99: found __[us]{8,16,32,64} type without
> #include
> Using my patch without modification does not cause
On Tue, Apr 16, 2013 at 11:21 AM, Linus Torvalds
wrote:
>> What I meant is IF is included by userspace (it sure is
>> meant to be included and *is* included by libfuse and other stuff)
>> THEN using instead of is fine regardless of
>> whether __linux__ is defined or not.
>
> That's probably
> What I meant is IF is included by userspace (it sure is
> meant to be included and *is* included by libfuse and other stuff)
> THEN using instead of is fine regardless of
> whether __linux__ is defined or not.
That's probably true. But the patch in question adds the __KERNEL__
test, and
On Tue, Apr 16, 2013 at 5:59 PM, Linus Torvalds
wrote:
> On Tue, Apr 16, 2013 at 7:21 AM, Miklos Szeredi wrote:
>>
>> And I still disagree. Why should userspace use the linux internal
>> header when there's a perfectly good standard header that it can use?
>
> If it's called UAPI, it damn well
On Tue, Apr 16, 2013 at 7:21 AM, Miklos Szeredi wrote:
>
> And I still disagree. Why should userspace use the linux internal
> header when there's a perfectly good standard header that it can use?
If it's called UAPI, it damn well is *meant* for user-space inclusion.
Look at the file-name.
And
On Mon, Apr 15, 2013 at 11:47 PM, Colin Cross wrote:
> On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross wrote:
>> Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse
>> header with one used in library) added #ifdef __linux__ around
>> defines if it is not set. The kernel build is
On Mon, Apr 15, 2013 at 11:47 PM, Colin Cross ccr...@android.com wrote:
On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross ccr...@android.com wrote:
Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse
header with one used in library) added #ifdef __linux__ around
defines if it is not
On Tue, Apr 16, 2013 at 7:21 AM, Miklos Szeredi mik...@szeredi.hu wrote:
And I still disagree. Why should userspace use the linux internal
header when there's a perfectly good standard header that it can use?
If it's called UAPI, it damn well is *meant* for user-space inclusion.
Look at the
On Tue, Apr 16, 2013 at 5:59 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
On Tue, Apr 16, 2013 at 7:21 AM, Miklos Szeredi mik...@szeredi.hu wrote:
And I still disagree. Why should userspace use the linux internal
header when there's a perfectly good standard header that it can use?
What I meant is IF linux/fuse.h is included by userspace (it sure is
meant to be included and *is* included by libfuse and other stuff)
THEN using stdint.h instead of linux/types.h is fine regardless of
whether __linux__ is defined or not.
That's probably true. But the patch in question adds
On Tue, Apr 16, 2013 at 11:21 AM, Linus Torvalds
torva...@linux-foundation.org wrote:
What I meant is IF linux/fuse.h is included by userspace (it sure is
meant to be included and *is* included by libfuse and other stuff)
THEN using stdint.h instead of linux/types.h is fine regardless of
On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross ccr...@android.com wrote:
Dropping __linux__ causes a make headers_check warning, which the
kbuild test robot reported this morning:
usr/include/linux/fuse.h:99: found __[us]{8,16,32,64} type without
#include linux/types.h
Using my patch without
On Tue, Apr 16, 2013 at 12:11 PM, Miklos Szeredi mik...@szeredi.hu wrote:
On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross ccr...@android.com wrote:
Dropping __linux__ causes a make headers_check warning, which the
kbuild test robot reported this morning:
usr/include/linux/fuse.h:99: found
On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross wrote:
> Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse
> header with one used in library) added #ifdef __linux__ around
> defines if it is not set. The kernel build is self-contained and
> can be built on non-Linux toolchains.
Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse
header with one used in library) added #ifdef __linux__ around
defines if it is not set. The kernel build is self-contained and
can be built on non-Linux toolchains. After the mentioned commit
builds on non-Linux toolchains will
Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse
header with one used in library) added #ifdef __linux__ around
defines if it is not set. The kernel build is self-contained and
can be built on non-Linux toolchains. After the mentioned commit
builds on non-Linux toolchains will
On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross ccr...@android.com wrote:
Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse
header with one used in library) added #ifdef __linux__ around
defines if it is not set. The kernel build is self-contained and
can be built on non-Linux
24 matches
Mail list logo
