Re: [PATCH] gpio: Renesas R-Car GPIO driver V3

2013-03-27 Thread Magnus Damm
On Thu, Mar 28, 2013 at 12:16 AM, Linus Walleij wrote: > On Tue, Mar 26, 2013 at 1:23 AM, Magnus Damm wrote: > >> From: Magnus Damm >> >> This patch is V3 of a GPIO driver for the R-Car series of >> SoCs from Renesas. This driver is designed to be reusable >> between multiple SoCs that share the

Re: [PATCH] gpio: Renesas R-Car GPIO driver V3

2013-03-27 Thread Linus Walleij
On Tue, Mar 26, 2013 at 1:23 AM, Magnus Damm wrote: > From: Magnus Damm > > This patch is V3 of a GPIO driver for the R-Car series of > SoCs from Renesas. This driver is designed to be reusable > between multiple SoCs that share the same basic building block, > but so far it has only been used o

Re: [PATCH] gpio: Renesas R-Car GPIO driver V3

2013-03-27 Thread Simon Horman
On Tue, Mar 26, 2013 at 11:16:30PM +0900, Magnus Damm wrote: > Hi Laurent, > > On Tue, Mar 26, 2013 at 10:03 PM, Laurent Pinchart > wrote: > > Hi Magnus, > > > > Thanks for the patch. > > > > On Tuesday 26 March 2013 09:23:01 Magnus Damm wrote: > >> From: Magnus Damm > >> > >> This patch is V3 o

Re: [PATCH] gpio: Renesas R-Car GPIO driver V3

2013-03-26 Thread Magnus Damm
Hi Laurent, On Tue, Mar 26, 2013 at 10:03 PM, Laurent Pinchart wrote: > Hi Magnus, > > Thanks for the patch. > > On Tuesday 26 March 2013 09:23:01 Magnus Damm wrote: >> From: Magnus Damm >> >> This patch is V3 of a GPIO driver for the R-Car series of >> SoCs from Renesas. This driver is designed

Re: [PATCH] gpio: Renesas R-Car GPIO driver V3

2013-03-26 Thread Laurent Pinchart
Hi Magnus, Thanks for the patch. On Tuesday 26 March 2013 09:23:01 Magnus Damm wrote: > From: Magnus Damm > > This patch is V3 of a GPIO driver for the R-Car series of > SoCs from Renesas. This driver is designed to be reusable > between multiple SoCs that share the same basic building block, >

[PATCH] gpio: Renesas R-Car GPIO driver V3

2013-03-25 Thread Magnus Damm
From: Magnus Damm This patch is V3 of a GPIO driver for the R-Car series of SoCs from Renesas. This driver is designed to be reusable between multiple SoCs that share the same basic building block, but so far it has only been used on R-Car H1 (r8a7779). Each driver instance handles 32 GPIOs with

Re: [PATCH] gpio: Renesas R-Car GPIO driver

2013-03-14 Thread Linus Walleij
On Thu, Mar 14, 2013 at 5:07 AM, Magnus Damm wrote: > On Thu, Mar 14, 2013 at 2:20 AM, Linus Walleij > wrote: >> It is quite common to request IRQ on *both* rising and falling edges, >> what happens then? (...) > I may be wrong, but the switch above does AND with IRQ_TYPE_SENSE_MASK > which mak

Re: [PATCH] gpio: Renesas R-Car GPIO driver

2013-03-13 Thread Magnus Damm
Hi Linus, On Thu, Mar 14, 2013 at 2:20 AM, Linus Walleij wrote: > On Tue, Mar 5, 2013 at 1:32 AM, Magnus Damm wrote: > >> +static int gpio_rcar_irq_set_type(struct irq_data *d, unsigned int type) >> +{ >> + struct gpio_rcar_priv *p = irq_data_get_irq_chip_data(d); >> + unsigned int h

Re: [PATCH] gpio: Renesas R-Car GPIO driver

2013-03-13 Thread Linus Walleij
On Tue, Mar 5, 2013 at 1:32 AM, Magnus Damm wrote: > +static int gpio_rcar_irq_set_type(struct irq_data *d, unsigned int type) > +{ > + struct gpio_rcar_priv *p = irq_data_get_irq_chip_data(d); > + unsigned int hwirq = irqd_to_hwirq(d); > + > + pr_debug("gpio: sense irq = %d, ty

Re: [PATCH] gpio: Renesas R-Car GPIO driver

2013-03-12 Thread Laurent Pinchart
Hi Magnus, On Tuesday 12 March 2013 14:27:25 Magnus Damm wrote: > On Sun, Mar 10, 2013 at 3:16 AM, Laurent Pinchart wrote: > > Hi Magnus, > > > > Thank you for the patch. > > Thanks for your review! You're welcome. > > On Tuesday 05 March 2013 09:32:19 Magnus Damm wrote: > >> From: Magnus Damm

Re: [PATCH] gpio: Renesas R-Car GPIO driver

2013-03-11 Thread Magnus Damm
HI Laurent, On Sun, Mar 10, 2013 at 3:16 AM, Laurent Pinchart wrote: > Hi Magnus, > > Thank you for the patch. Thanks for your review! > On Tuesday 05 March 2013 09:32:19 Magnus Damm wrote: >> From: Magnus Damm >> >> This patch implements a GPIO driver for the R-Car series >> of SoCs from Rene

Re: [PATCH] gpio: Renesas R-Car GPIO driver

2013-03-09 Thread Laurent Pinchart
Hi Magnus, Thank you for the patch. On Tuesday 05 March 2013 09:32:19 Magnus Damm wrote: > From: Magnus Damm > > This patch implements a GPIO driver for the R-Car series > of SoCs from Renesas. This driver is designed to be reusable > between multiple SoCs that share the same basic building blo

[PATCH] gpio: Renesas R-Car GPIO driver

2013-03-04 Thread Magnus Damm
From: Magnus Damm This patch implements a GPIO driver for the R-Car series of SoCs from Renesas. This driver is designed to be reusable between multiple SoCs that share the same basic building block, but so far it has only been used on R-Car H1 (r8a7779). Each driver instance handles 32 GPIOs wi