On Tue, Feb 11, 2014 at 9:57 AM, Lee Jones wrote:
>> >> Time to revisit this decision
>> >>
>> >> So, based on the fact that children device names usually contain
>> >> dashes, I do not understand why hwmon would be any special in this
>> >> regard. It is possible that the hwmon developers hav
On Tue, Feb 11, 2014 at 10:22 AM, Laszlo Papp wrote:
> On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>>> >> > Additionally, dashes are explicitly forbidden in hwmon
>>> >> > device names.
>>> >>
>>> >> Also, where is that documented
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> >> > Additionally, dashes are explicitly forbidden in hwmon
>> >> > device names.
>> >>
>> >> Also, where is that documented?
>> >
>> > In Documentation/hwmon/sysfs-interface:
>> >
>> >
> >> Time to revisit this decision
> >>
> >> So, based on the fact that children device names usually contain
> >> dashes, I do not understand why hwmon would be any special in this
> >> regard. It is possible that the hwmon developers have not faced much
> >> MFD situation before, and so, this
On Tue, Feb 11, 2014 at 9:47 AM, Lee Jones wrote:
>> >> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> >> >> > Additionally, dashes are explicitly forbidden in hwmon
>> >> >> > device names.
>> >> >>
>> >> >> Also, where is that documented?
>> >> >
>> >> > In Documentation/hwmon/sysfs
> >> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> >> >> > Additionally, dashes are explicitly forbidden in hwmon
> >> >> > device names.
> >> >>
> >> >> Also, where is that documented?
> >> >
> >> > In Documentation/hwmon/sysfs-interface:
> >> >
> >> > *
> >> > * G
On Tue, Feb 11, 2014 at 8:58 AM, Laszlo Papp wrote:
> On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>>> >> > Additionally, dashes are explicitly forbidden in hwmon
>>> >> > device names.
>>> >>
>>> >> Also, where is that documented?
On Tue, Feb 11, 2014 at 8:49 AM, Jean Delvare wrote:
> Le Tuesday 11 February 2014 à 08:28 +, Laszlo Papp a écrit :
>> On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
>> > Hi Laszlo,
>> >
>> > On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
>> >> On Mon, Feb 10, 2014 at 4:38 PM, J
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> >> > Additionally, dashes are explicitly forbidden in hwmon
>> >> > device names.
>> >>
>> >> Also, where is that documented?
>> >
>> > In Documentation/hwmon/sysfs-interface:
>> >
>> >
> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> >> > Additionally, dashes are explicitly forbidden in hwmon
> >> > device names.
> >>
> >> Also, where is that documented?
> >
> > In Documentation/hwmon/sysfs-interface:
> >
> > *
> > * Global attributes *
> > ***
Le Tuesday 11 February 2014 à 08:28 +, Laszlo Papp a écrit :
> On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
> > Hi Laszlo,
> >
> > On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> >> > Additionally, dashes are explicitl
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
> Hi Laszlo,
>
> On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
>> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> > Additionally, dashes are explicitly forbidden in hwmon
>> > device names.
>>
>> Also, where is that documented?
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
> Hi Laszlo,
>
> On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
>> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> > Additionally, dashes are explicitly forbidden in hwmon
>> > device names.
>>
>> Also, where is that documented?
Hi Laszlo,
On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> > Additionally, dashes are explicitly forbidden in hwmon
> > device names.
>
> Also, where is that documented?
In Documentation/hwmon/sysfs-interface:
On Tue, Feb 11, 2014 at 3:23 AM, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 11:10 PM, Guenter Roeck wrote:
>> On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
>> I think I'll let Jean handle this one.
>
> Guys, please be a bit more definite.
>
> We should get over this long ping-pon
On Mon, Feb 10, 2014 at 11:10 PM, Guenter Roeck wrote:
> On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
> I think I'll let Jean handle this one.
Guys, please be a bit more definite.
We should get over this long ping-pong game. It has been clearly
stated that either way is fine, and
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> Additionally, dashes are explicitly forbidden in hwmon
> device names.
Also, where is that documented?
I do not think you can make such a decision, and you will realize that
once you begin to think a bit out of the box and look around. See h
On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 4:53 PM, wrote:
> > Quoting Jean Delvare :
> >
> >>
> >> That being said, going with MFD in this case seems quite overkill to
> >> me. MFD makes a lot of sense when each function has its own resources.
> >> As
On Mon, Feb 10, 2014 at 4:53 PM, wrote:
> Quoting Jean Delvare :
>
>>
>> That being said, going with MFD in this case seems quite overkill to
>> me. MFD makes a lot of sense when each function has its own resources.
>> As this isn't the case here, a single driver registering both an hwmon
>> inte
On Mon, 10 Feb 2014 18:27:07 +, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 5:43 PM, Jean Delvare wrote:
> > On Mon, 10 Feb 2014 16:58:53 +, Lee Jones wrote:
> >> > > Might be worth taking the opportunity to swap out these magic numbers
> >> > > now.
> >> >
> >> > There's nothing magic ab
On Mon, Feb 10, 2014 at 5:43 PM, Jean Delvare wrote:
> Hi Lee,
>
> On Mon, 10 Feb 2014 16:58:53 +, Lee Jones wrote:
>> > > > static const struct i2c_device_id max6650_id[] = {
>> > > > - { "max6650", 1 },
>> > > > - { "max6651", 4 },
>> > > > + { "max6650-hwmon", 1 },
>> > >
> > > > > > Might be worth taking the opportunity to swap out these magic
> > > > > > numbers
> > > > > > now.
> > > > >
> > > > > There's nothing magic about them, they tell the driver how many fans
> > > > > each device supports. If you don't pass them as driver_data you'll
> > > > > have
> >
On Mon, 10 Feb 2014 18:01:59 +, Lee Jones wrote:
> > > > > Might be worth taking the opportunity to swap out these magic numbers
> > > > > now.
> > > >
> > > > There's nothing magic about them, they tell the driver how many fans
> > > > each device supports. If you don't pass them as driver_da
> > > > Might be worth taking the opportunity to swap out these magic numbers
> > > > now.
> > >
> > > There's nothing magic about them, they tell the driver how many fans
> > > each device supports. If you don't pass them as driver_data you'll have
> > > to derive them from the device name in the
Hi Lee,
On Mon, 10 Feb 2014 16:58:53 +, Lee Jones wrote:
> > > > static const struct i2c_device_id max6650_id[] = {
> > > > - { "max6650", 1 },
> > > > - { "max6651", 4 },
> > > > + { "max6650-hwmon", 1 },
> > > > + { "max6651-hwmon", 4 },
> >
> > No, this is not acce
On Mon, Feb 10, 2014 at 5:06 PM, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> Hi Lee, Laszlo,
>>
>> On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
>>> > In the preparation of creating an mfd driver and then refactor this one
>>> > into a
>>> > platform drive
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> Hi Lee, Laszlo,
>
> On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
>> > In the preparation of creating an mfd driver and then refactor this one
>> > into a
>> > platform driver in order to add some pinctrl functionality to the chip, it
> > > static const struct i2c_device_id max6650_id[] = {
> > > - { "max6650", 1 },
> > > - { "max6651", 4 },
> > > + { "max6650-hwmon", 1 },
> > > + { "max6651-hwmon", 4 },
>
> No, this is not acceptable, sorry. This will change the name of the
> hwmon device as seen from user-space, breaking any
Quoting Jean Delvare :
That being said, going with MFD in this case seems quite overkill to
me. MFD makes a lot of sense when each function has its own resources.
As this isn't the case here, a single driver registering both an hwmon
interface and a pinctrl interface would seem sufficient to me
Hi Lee, Laszlo,
On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
> > In the preparation of creating an mfd driver and then refactor this one
> > into a
> > platform driver in order to add some pinctrl functionality to the chip, it
> > is
> > necessary to start the series with this change so
> In the preparation of creating an mfd driver and then refactor this one into a
> platform driver in order to add some pinctrl functionality to the chip, it is
> necessary to start the series with this change so that the mfd driver can
> refer
> to the proper name in the subsequent change without
In the preparation of creating an mfd driver and then refactor this one into a
platform driver in order to add some pinctrl functionality to the chip, it is
necessary to start the series with this change so that the mfd driver can refer
to the proper name in the subsequent change without making cha
32 matches
Mail list logo
