Re: [PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-24 Thread Wolfram Sang
On Thu, Sep 13, 2018 at 08:30:10PM -0700, Guenter Roeck wrote: > Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events > properly") moved interrupt acknowledgment to the end of the interrupt > handler. In part this was done because the AST2500 datasheet says: > > I2CD10 Inter

Re: [PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-17 Thread Brendan Higgins
On Mon, Sep 17, 2018 at 6:11 PM Joel Stanley wrote: > > On Fri, 14 Sep 2018 at 13:00, Guenter Roeck wrote: > > > > Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events > > properly") moved interrupt acknowledgment to the end of the interrupt > > handler. In part this was don

Re: [PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-17 Thread Joel Stanley
On Fri, 14 Sep 2018 at 13:00, Guenter Roeck wrote: > > Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events > properly") moved interrupt acknowledgment to the end of the interrupt > handler. In part this was done because the AST2500 datasheet says: > > I2CD10 Interrupt Statu

Re: [PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-17 Thread Guenter Roeck
On Mon, Sep 17, 2018 at 10:16:59AM -0700, Jae Hyun Yoo wrote: > On 9/17/2018 9:34 AM, Wolfram Sang wrote: > > > >>Looks good to me. Thanks! :) > >> > >>Acked-by: Jae Hyun Yoo > > > >Does that mean I need to revert "[PATCH i2c-next v6] i2c: aspeed: Handle > >master/slave combined irq events properl

Re: [PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-17 Thread Jae Hyun Yoo
On 9/17/2018 9:34 AM, Wolfram Sang wrote: Looks good to me. Thanks! :) Acked-by: Jae Hyun Yoo Does that mean I need to revert "[PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly" in i2c/for-next? And apply this to i2c/for-current? (and please quote only relev

Re: [PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-17 Thread Wolfram Sang
> Looks good to me. Thanks! :) > > Acked-by: Jae Hyun Yoo Does that mean I need to revert "[PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly" in i2c/for-next? And apply this to i2c/for-current? (and please quote only relevat parts of a message when replying)

Re: [PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-14 Thread Jae Hyun Yoo
On 9/13/2018 8:30 PM, Guenter Roeck wrote: Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") moved interrupt acknowledgment to the end of the interrupt handler. In part this was done because the AST2500 datasheet says: I2CD10 Interrupt Status Register bi

[PATCH] i2c: aspeed: Acknowledge most interrupts early in interrupt handler

2018-09-13 Thread Guenter Roeck
Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") moved interrupt acknowledgment to the end of the interrupt handler. In part this was done because the AST2500 datasheet says: I2CD10 Interrupt Status Register bit 2 Receive Done Interrupt status S/W