Re: [PATCH] idr: Document ida tree sections

2013-08-14 Thread Tejun Heo
Hello, Kent. On Wed, Aug 14, 2013 at 05:04:27PM -0700, Kent Overstreet wrote: > I was just telling you how I felt :) Regardless of that, IMO what I've > got now is superior to any radix tree based approach for what ida/idr > are supposed to do. I could of course be wrong, but I'm not convinced...

Re: [PATCH] idr: Document ida tree sections

2013-08-14 Thread Kent Overstreet
On Tue, Aug 13, 2013 at 07:59:47PM -0400, Tejun Heo wrote: > Hey, Kent. > > On Tue, Aug 13, 2013 at 04:51:33PM -0700, Kent Overstreet wrote: > > Should probably be almost as good, yeah... in theory, but the space > > efficiency still isn't going to be as good, and it'll probably be more > > code..

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Tejun Heo
Hey, Kent. On Tue, Aug 13, 2013 at 04:51:33PM -0700, Kent Overstreet wrote: > Should probably be almost as good, yeah... in theory, but the space > efficiency still isn't going to be as good, and it'll probably be more > code... and at this point I really just don't want to futz with it more. > At

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Kent Overstreet
On Tue, Aug 13, 2013 at 07:22:11PM -0400, Tejun Heo wrote: > Hello, > > On Tue, Aug 13, 2013 at 03:59:27PM -0700, Kent Overstreet wrote: > > > Well, it's not necessarily about requiring it but more about surviving > > > it with some grace when things don't go as expected, which is an > > > importa

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Tejun Heo
Hello, On Tue, Aug 13, 2013 at 03:59:27PM -0700, Kent Overstreet wrote: > > Well, it's not necessarily about requiring it but more about surviving > > it with some grace when things don't go as expected, which is an > > important characteristic for common library stuff. > > The patch I posted sho

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Kent Overstreet
On Tue, Aug 13, 2013 at 06:44:28PM -0400, Tejun Heo wrote: > Hello, Kent. > > On Tue, Aug 13, 2013 at 03:27:59PM -0700, Kent Overstreet wrote: > > It's only naturally a radix tree problem _if_ you require sparseness. > > Well, it's not necessarily about requiring it but more about surviving > it

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Tejun Heo
Hello, Kent. On Tue, Aug 13, 2013 at 03:27:59PM -0700, Kent Overstreet wrote: > It's only naturally a radix tree problem _if_ you require sparseness. Well, it's not necessarily about requiring it but more about surviving it with some grace when things don't go as expected, which is an important c

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Kent Overstreet
On Fri, Aug 09, 2013 at 10:57:56AM -0400, Tejun Heo wrote: > Hello, > > On Wed, Aug 07, 2013 at 01:51:17PM -0700, Kent Overstreet wrote: > > + * So if the max section size is 64k, that's ~4096 sections, with 8 byte > > + * pointers that's a little over 32k for the pointers to sections. > > + * > >

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Kent Overstreet
On Tue, Aug 13, 2013 at 06:19:28PM -0400, Tejun Heo wrote: > Hello, > > On Tue, Aug 13, 2013 at 03:13:08PM -0700, Kent Overstreet wrote: > > If you're convinced this is a real issue though - how about > > It is a real issue. Large order allocation is fine for optimization > but shouldn't be depe

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Tejun Heo
Hello, On Tue, Aug 13, 2013 at 03:13:08PM -0700, Kent Overstreet wrote: > If you're convinced this is a real issue though - how about It is a real issue. Large order allocation is fine for optimization but shouldn't be depended upon. It does fail easily without compaction and compaction is heav

Re: [PATCH] idr: Document ida tree sections

2013-08-13 Thread Kent Overstreet
On Fri, Aug 09, 2013 at 10:57:56AM -0400, Tejun Heo wrote: > Hello, > > On Wed, Aug 07, 2013 at 01:51:17PM -0700, Kent Overstreet wrote: > > + * So if the max section size is 64k, that's ~4096 sections, with 8 byte > > + * pointers that's a little over 32k for the pointers to sections. > > + * > >

Re: [PATCH] idr: Document ida tree sections

2013-08-09 Thread Tejun Heo
Hello, On Wed, Aug 07, 2013 at 01:51:17PM -0700, Kent Overstreet wrote: > + * So if the max section size is 64k, that's ~4096 sections, with 8 byte > + * pointers that's a little over 32k for the pointers to sections. > + * > + * That means max size sections are order 4 page allocations. Order 4

[PATCH] idr: Document ida tree sections

2013-08-07 Thread Kent Overstreet
rom: Kent Overstreet Date: Wed, 7 Aug 2013 13:50:42 -0700 Subject: [PATCH] idr: Document ida tree sections diff --git a/lib/idr.c b/lib/idr.c index 320ffea..02a221c 100644 --- a/lib/idr.c +++ b/lib/idr.c @@ -72,18 +72,37 @@ static void *kgalloc(size_t size, gfp_t gfp) * the bit for id i