Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Leon Romanovsky
On Fri, Sep 07, 2018 at 06:25:03PM +0300, Igor Stoppa wrote: > On 07/09/18 18:13, Doug Ledford wrote: > > > This patch was part of a larger series on lkml. In that context, I > > acked it so that the series could be applied by whomever took it (it > > didn't belong on rdma-list as a series since

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Leon Romanovsky
On Fri, Sep 07, 2018 at 06:25:03PM +0300, Igor Stoppa wrote: > On 07/09/18 18:13, Doug Ledford wrote: > > > This patch was part of a larger series on lkml. In that context, I > > acked it so that the series could be applied by whomever took it (it > > didn't belong on rdma-list as a series since

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Igor Stoppa
On 07/09/18 18:13, Doug Ledford wrote: This patch was part of a larger series on lkml. In that context, I acked it so that the series could be applied by whomever took it (it didn't belong on rdma-list as a series since only one patch out of some large number touched rdma files). Now it is

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Igor Stoppa
On 07/09/18 18:13, Doug Ledford wrote: This patch was part of a larger series on lkml. In that context, I acked it so that the series could be applied by whomever took it (it didn't belong on rdma-list as a series since only one patch out of some large number touched rdma files). Now it is

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Doug Ledford
On Wed, 2018-09-05 at 09:01 +0300, Leon Romanovsky wrote: > On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: > > Typically the assert is expected to not fail. > > This whole assert can be removed. > > > > > Signed-off-by: Igor Stoppa > > Acked-by: Doug Ledford > > Most probably

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Doug Ledford
On Wed, 2018-09-05 at 09:01 +0300, Leon Romanovsky wrote: > On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: > > Typically the assert is expected to not fail. > > This whole assert can be removed. > > > > > Signed-off-by: Igor Stoppa > > Acked-by: Doug Ledford > > Most probably

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-05 Thread Igor Stoppa
On 05/09/18 09:01, Leon Romanovsky wrote: On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: Typically the assert is expected to not fail. This whole assert can be removed. ok Signed-off-by: Igor Stoppa Acked-by: Doug Ledford Most probably that I missed discussion, but

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-05 Thread Igor Stoppa
On 05/09/18 09:01, Leon Romanovsky wrote: On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: Typically the assert is expected to not fail. This whole assert can be removed. ok Signed-off-by: Igor Stoppa Acked-by: Doug Ledford Most probably that I missed discussion, but

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-05 Thread Leon Romanovsky
On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: > Typically the assert is expected to not fail. This whole assert can be removed. > > Signed-off-by: Igor Stoppa > Acked-by: Doug Ledford Most probably that I missed discussion, but anyway, does this "Acked-by" come from internal or

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-05 Thread Leon Romanovsky
On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: > Typically the assert is expected to not fail. This whole assert can be removed. > > Signed-off-by: Igor Stoppa > Acked-by: Doug Ledford Most probably that I missed discussion, but anyway, does this "Acked-by" come from internal or

[PATCH] infiniband: nes: add unlikely() to assert()

2018-08-31 Thread Igor Stoppa
Typically the assert is expected to not fail. Signed-off-by: Igor Stoppa Acked-by: Doug Ledford Cc: Faisal Latif Cc: Chien Tung Cc: Roland Dreier Cc: Faisal Latif Cc: Jason Gunthorpe Cc: linux-r...@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/infiniband/hw/nes/nes.h | 2 +-

[PATCH] infiniband: nes: add unlikely() to assert()

2018-08-31 Thread Igor Stoppa
Typically the assert is expected to not fail. Signed-off-by: Igor Stoppa Acked-by: Doug Ledford Cc: Faisal Latif Cc: Chien Tung Cc: Roland Dreier Cc: Faisal Latif Cc: Jason Gunthorpe Cc: linux-r...@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/infiniband/hw/nes/nes.h | 2 +-