Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2018-01-16 Thread Dmitry Torokhov
On Fri, Nov 17, 2017 at 03:51:31PM +0100, Philippe Ombredanne wrote: > On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman > wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > >

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2018-01-16 Thread Dmitry Torokhov
On Fri, Nov 17, 2017 at 03:51:31PM +0100, Philippe Ombredanne wrote: > On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman > wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Dmitry Torokhov
On Sat, Nov 18, 2017 at 11:27:24AM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 17, 2017 at 12:33:13PM -0800, Dmitry Torokhov wrote: > > On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > > the

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Dmitry Torokhov
On Sat, Nov 18, 2017 at 11:27:24AM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 17, 2017 at 12:33:13PM -0800, Dmitry Torokhov wrote: > > On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > > the

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Philippe Ombredanne
On Sat, Nov 18, 2017 at 1:49 PM, Greg Kroah-Hartman wrote: > On Sat, Nov 18, 2017 at 01:39:03PM +0100, Philippe Ombredanne wrote: >> On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman >> wrote: >> > >> > Please do, I got rid of all of the

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Philippe Ombredanne
On Sat, Nov 18, 2017 at 1:49 PM, Greg Kroah-Hartman wrote: > On Sat, Nov 18, 2017 at 01:39:03PM +0100, Philippe Ombredanne wrote: >> On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman >> wrote: >> > >> > Please do, I got rid of all of the DRIVER_VERSION crap in the >> > drivers/usb/ tree a

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Greg Kroah-Hartman
On Sat, Nov 18, 2017 at 01:39:03PM +0100, Philippe Ombredanne wrote: > On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman > wrote: > > > > Please do, I got rid of all of the DRIVER_VERSION crap in the > > drivers/usb/ tree a release or so ago, as they make no sense

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Greg Kroah-Hartman
On Sat, Nov 18, 2017 at 01:39:03PM +0100, Philippe Ombredanne wrote: > On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman > wrote: > > > > Please do, I got rid of all of the DRIVER_VERSION crap in the > > drivers/usb/ tree a release or so ago, as they make no sense at all. > > The other defines

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Philippe Ombredanne
On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman wrote: > > Please do, I got rid of all of the DRIVER_VERSION crap in the > drivers/usb/ tree a release or so ago, as they make no sense at all. > The other defines are also really silly and can be cleaned up too. > >

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Philippe Ombredanne
On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman wrote: > > Please do, I got rid of all of the DRIVER_VERSION crap in the > drivers/usb/ tree a release or so ago, as they make no sense at all. > The other defines are also really silly and can be cleaned up too. > > Want me to do that for

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Greg Kroah-Hartman
On Fri, Nov 17, 2017 at 12:33:13PM -0800, Dmitry Torokhov wrote: > On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-18 Thread Greg Kroah-Hartman
On Fri, Nov 17, 2017 at 12:33:13PM -0800, Dmitry Torokhov wrote: > On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-17 Thread Dmitry Torokhov
On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-17 Thread Dmitry Torokhov
On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-17 Thread Philippe Ombredanne
On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code

Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-17 Thread Philippe Ombredanne
On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, as

[PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-17 Thread Greg Kroah-Hartman
There is no need to #define the license of the driver, just put it in the MODULE_LICENSE() line directly as a text string. This allows tools that check that the module license matches the source code license to work properly, as there is no need to unwind the unneeded dereference. For some of

[PATCH] input: remove unneeded DRIVER_LICENSE #defines

2017-11-17 Thread Greg Kroah-Hartman
There is no need to #define the license of the driver, just put it in the MODULE_LICENSE() line directly as a text string. This allows tools that check that the module license matches the source code license to work properly, as there is no need to unwind the unneeded dereference. For some of