Re: [PATCH] ipc: always handle a new value of auto_msgmni

2014-08-18 Thread Andrew Vagin
On Sat, Aug 16, 2014 at 10:29:16PM +0200, Manfred Spraul wrote: > Hi Andrew, > > On 08/14/2014 03:34 PM, Andrew Vagin wrote: > >On Thu, Aug 14, 2014 at 11:37:45AM +0200, Manfred Spraul wrote: > >>Hi Andrey, > >> > >>[...] > >>What do you use auto_msgmni for? > >We disable it to check that criu res

Re: [PATCH] ipc: always handle a new value of auto_msgmni

2014-08-16 Thread Manfred Spraul
Hi Andrew, On 08/14/2014 03:34 PM, Andrew Vagin wrote: On Thu, Aug 14, 2014 at 11:37:45AM +0200, Manfred Spraul wrote: Hi Andrey, [...] What do you use auto_msgmni for? We disable it to check that criu restores a value of the msgmni sysctl correctly. https://github.com/xemul/criu/blob/mast

Re: [PATCH] ipc: always handle a new value of auto_msgmni

2014-08-14 Thread Andrew Vagin
On Thu, Aug 14, 2014 at 11:37:45AM +0200, Manfred Spraul wrote: > Hi Andrey, > > On 08/13/2014 03:21 PM, Andrey Vagin wrote: > >proc_dointvec_minmax() returns zero, if a new value has been set. > >So we don't need to check all charectes have been handled. > What do you use auto_msgmni for? We dis

Re: [PATCH] ipc: always handle a new value of auto_msgmni

2014-08-14 Thread Manfred Spraul
Hi Andrey, On 08/13/2014 03:21 PM, Andrey Vagin wrote: proc_dointvec_minmax() returns zero, if a new value has been set. So we don't need to check all charectes have been handled. What do you use auto_msgmni for? I would propose to remove the whole logic - just always allow 32000 message queu

[PATCH] ipc: always handle a new value of auto_msgmni

2014-08-13 Thread Andrey Vagin
proc_dointvec_minmax() returns zero, if a new value has been set. So we don't need to check all charectes have been handled. Below you can find two examples. In the new value has not been handled properly. $ strace ./a.out open("/proc/sys/kernel/auto_msgmni", O_WRONLY) = 3 write(3, "0\n\0", 3)