Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()

2020-07-20 Thread Greg Kroah-Hartman
On Mon, Jul 20, 2020 at 02:07:50PM +0200, Markus Elfring wrote: > > > __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an > > > error path. So we can remove duplicate code in the if (rv). > > > > Looks correct, queued for next release. > > 1. Can an imperative wording be preferre

Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()

2020-07-20 Thread Markus Elfring
> > __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an > > error path. So we can remove duplicate code in the if (rv). > > Looks correct, queued for next release. 1. Can an imperative wording be preferred for the change description? 2. Will the tag “Fixes” become helpful for th