Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-20 Thread David Abdurachmanov
On Tue, Sep 17, 2019 at 3:26 PM Paul Walmsley wrote: > > > Just tested this on the SiFive HiFive Unleashed. Seems to work OK; > however I did not stress-test it. > > Tested-by: Paul Walmsley # HiFive Unleashed > > > - Paul > > > # !cat > cat /proc/interrupts >CPU0 CPU1 CP

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-17 Thread Paul Walmsley
Just tested this on the SiFive HiFive Unleashed. Seems to work OK; however I did not stress-test it. Tested-by: Paul Walmsley # HiFive Unleashed - Paul # !cat cat /proc/interrupts CPU0 CPU1 CPU2 CPU3 1: 0 0 0 0 Si

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-16 Thread Christoph Hellwig
With the fixes it seems to still work fine on the Kendryte KD210. Although currently only the serial interrupt is tested and this might not be a very exhaustive test case..

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-16 Thread Palmer Dabbelt
On Mon, 16 Sep 2019 14:33:23 PDT (-0700), m...@kernel.org wrote: On Mon, 16 Sep 2019 13:51:58 -0700 (PDT) Palmer Dabbelt wrote: On Mon, 16 Sep 2019 12:04:56 PDT (-0700), Darius Rad wrote: > On 9/15/19 2:20 PM, Marc Zyngier wrote: >> On Sun, 15 Sep 2019 18:31:33 +0100, >> Palmer Dabbelt wrote:

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-16 Thread Palmer Dabbelt
On Mon, 16 Sep 2019 14:41:07 PDT (-0700), Darius Rad wrote: On 9/16/19 4:51 PM, Palmer Dabbelt wrote: On Mon, 16 Sep 2019 12:04:56 PDT (-0700), Darius Rad wrote: On 9/15/19 2:20 PM, Marc Zyngier wrote: On Sun, 15 Sep 2019 18:31:33 +0100, Palmer Dabbelt wrote: Hi Palmer, On Sun, 15 Sep 201

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-16 Thread Darius Rad
On 9/16/19 4:51 PM, Palmer Dabbelt wrote: > On Mon, 16 Sep 2019 12:04:56 PDT (-0700), Darius Rad wrote: >> On 9/15/19 2:20 PM, Marc Zyngier wrote: >>> On Sun, 15 Sep 2019 18:31:33 +0100, >>> Palmer Dabbelt wrote: >>> >>> Hi Palmer, >>> On Sun, 15 Sep 2019 07:24:20 PDT (-0700), m...@kerne

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-16 Thread Marc Zyngier
On Mon, 16 Sep 2019 13:51:58 -0700 (PDT) Palmer Dabbelt wrote: > On Mon, 16 Sep 2019 12:04:56 PDT (-0700), Darius Rad wrote: > > On 9/15/19 2:20 PM, Marc Zyngier wrote: > >> On Sun, 15 Sep 2019 18:31:33 +0100, > >> Palmer Dabbelt wrote: > >> > >> Hi Palmer, > >> > >>> > >>> On Sun, 15 Sep 20

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-16 Thread Palmer Dabbelt
On Mon, 16 Sep 2019 12:04:56 PDT (-0700), Darius Rad wrote: On 9/15/19 2:20 PM, Marc Zyngier wrote: On Sun, 15 Sep 2019 18:31:33 +0100, Palmer Dabbelt wrote: Hi Palmer, On Sun, 15 Sep 2019 07:24:20 PDT (-0700), m...@kernel.org wrote: On Thu, 12 Sep 2019 22:40:34 +0100, Darius Rad wrote:

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-16 Thread Darius Rad
On 9/15/19 2:20 PM, Marc Zyngier wrote: > On Sun, 15 Sep 2019 18:31:33 +0100, > Palmer Dabbelt wrote: > > Hi Palmer, > >> >> On Sun, 15 Sep 2019 07:24:20 PDT (-0700), m...@kernel.org wrote: >>> On Thu, 12 Sep 2019 22:40:34 +0100, >>> Darius Rad wrote: >>> >>> Hi Darius, >>> As per the

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-15 Thread Palmer Dabbelt
On Sun, 15 Sep 2019 11:20:40 PDT (-0700), m...@kernel.org wrote: On Sun, 15 Sep 2019 18:31:33 +0100, Palmer Dabbelt wrote: Hi Palmer, On Sun, 15 Sep 2019 07:24:20 PDT (-0700), m...@kernel.org wrote: > On Thu, 12 Sep 2019 22:40:34 +0100, > Darius Rad wrote: > > Hi Darius, > >> >> As per the

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-15 Thread Marc Zyngier
On Sun, 15 Sep 2019 18:31:33 +0100, Palmer Dabbelt wrote: Hi Palmer, > > On Sun, 15 Sep 2019 07:24:20 PDT (-0700), m...@kernel.org wrote: > > On Thu, 12 Sep 2019 22:40:34 +0100, > > Darius Rad wrote: > > > > Hi Darius, > > > >> > >> As per the existing comment, irq_mask and irq_unmask do no

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-15 Thread Palmer Dabbelt
On Sun, 15 Sep 2019 07:24:20 PDT (-0700), m...@kernel.org wrote: On Thu, 12 Sep 2019 22:40:34 +0100, Darius Rad wrote: Hi Darius, As per the existing comment, irq_mask and irq_unmask do not need to do anything for the PLIC. However, the functions must exist (the pointers cannot be NULL) as

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-15 Thread Marc Zyngier
On Thu, 12 Sep 2019 22:40:34 +0100, Darius Rad wrote: Hi Darius, > > As per the existing comment, irq_mask and irq_unmask do not need > to do anything for the PLIC. However, the functions must exist > (the pointers cannot be NULL) as they are not optional, based on > the documentation (Documen

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-14 Thread Palmer Dabbelt
On Sat, 14 Sep 2019 12:42:32 PDT (-0700), charles.papon...@gmail.com wrote: I had issues with that plic driver. The current implementation wasn't usable with driver using level sensitive interrupt together with the IRQF_ONESHOT flag. Those null were producing crashes in the chained_irq_enter fun

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-14 Thread Charles Papon
I had issues with that plic driver. The current implementation wasn't usable with driver using level sensitive interrupt together with the IRQF_ONESHOT flag. Those null were producing crashes in the chained_irq_enter function. Filling them with dummy function fixed the issue. On Sat, Sep 14, 2019

Re: [PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-14 Thread Palmer Dabbelt
On Thu, 12 Sep 2019 14:40:34 PDT (-0700), Darius Rad wrote: As per the existing comment, irq_mask and irq_unmask do not need to do anything for the PLIC. However, the functions must exist (the pointers cannot be NULL) as they are not optional, based on the documentation (Documentation/core-api/g

[PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-12 Thread Darius Rad
As per the existing comment, irq_mask and irq_unmask do not need to do anything for the PLIC. However, the functions must exist (the pointers cannot be NULL) as they are not optional, based on the documentation (Documentation/core-api/genericirq.rst) as well as existing usage (e.g., include/linux/