Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format

2019-03-12 Thread Steven Rostedt
On Tue, 12 Mar 2019 05:08:30 -0400 valdis.kletni...@vt.edu wrote: > On Tue, 12 Mar 2019 04:58:32 -0400, "Valdis Klētnieks" said: > > > > CC kernel/trace/trace_kprobe.o > > kernel/trace/trace_kprobe.c:41: warning: cannot understand function > > prototype: 'struct trace_kprobe ' > > > > The

Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format

2019-03-12 Thread Steven Rostedt
On Tue, 12 Mar 2019 08:14:52 -0700 Randy Dunlap wrote: > > NACK. > > > > This isn't a kernel doc comment, and I don't want to make it one when > > it is not. Just ignore that warning. > > > > -- Steve > > Huh? The patch doesn't do that -- it does the opposite of that. > I.e., begin a non-ke

Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format

2019-03-12 Thread Randy Dunlap
On 3/12/19 8:01 AM, Steven Rostedt wrote: > On Tue, 12 Mar 2019 04:58:32 -0400 > "Valdis Klētnieks" wrote: > >> CC kernel/trace/trace_kprobe.o >> kernel/trace/trace_kprobe.c:41: warning: cannot understand function >> prototype: 'struct trace_kprobe ' >> >> The real problem is that a comme

Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format

2019-03-12 Thread Steven Rostedt
On Tue, 12 Mar 2019 04:58:32 -0400 "Valdis Klētnieks" wrote: > CC kernel/trace/trace_kprobe.o > kernel/trace/trace_kprobe.c:41: warning: cannot understand function > prototype: 'struct trace_kprobe ' > > The real problem is that a comment looked like kerneldoc when it shouldn't > be...

[PATCH] kernel/trace/trace_kprobe.c - fix comment format

2019-03-12 Thread Valdis Klētnieks
CC kernel/trace/trace_kprobe.o kernel/trace/trace_kprobe.c:41: warning: cannot understand function prototype: 'struct trace_kprobe ' The real problem is that a comment looked like kerneldoc when it shouldn't be... Signed-off-by: Valdis Kletnieks diff --git a/kernel/trace/trace_kprobe.