Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-06 Thread Bryan Wu
On Tue, Mar 5, 2013 at 9:01 PM, Mark Brown wrote: > Provide some trace, though the hardware is most likely non-functional if > this happens. > Thanks for the update, I will merge it. -Bryan > Signed-off-by: Mark Brown > --- > drivers/leds/leds-wm8350.c |5 - > 1 file changed, 4 insert

[PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-05 Thread Mark Brown
Provide some trace, though the hardware is most likely non-functional if this happens. Signed-off-by: Mark Brown --- drivers/leds/leds-wm8350.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c index ed15157..8a181d

Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-05 Thread Mark Brown
On Tue, Mar 05, 2013 at 11:03:52AM -0800, Bryan Wu wrote: > On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown > > if (ret != 0) { > > dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", > > ret); > > - regulator_enable(led->dcdc); > > + ret = regu

Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-05 Thread Bryan Wu
On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown wrote: > Provide some trace, though the hardware is most likely non-functional if > this happens. > > Signed-off-by: Mark Brown > --- > drivers/leds/leds-wm8350.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/

[PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-01 Thread Mark Brown
Provide some trace, though the hardware is most likely non-functional if this happens. Signed-off-by: Mark Brown --- drivers/leds/leds-wm8350.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c index ed15157..86bda