Re: [PATCH] libata: Ignore spurious PHY events on LPM policy change

2015-04-25 Thread Gabriele Mazzotta
On Saturday 25 April 2015 11:37:51 Tejun Heo wrote: > I thought more about it and it's weird to have ATA_LFLAG_CHANGED and > last_lpm_change timestamp in libata core side and then open-code the > actual logic in ahci. How about implementing a generic helper, say, > bool sata_lpm_ignore_phy_events(

Re: [PATCH] libata: Ignore spurious PHY events on LPM policy change

2015-04-25 Thread Tejun Heo
On Sat, Apr 25, 2015 at 11:34:29AM +0200, Gabriele Mazzotta wrote: > When the LPM policy is set to ATA_LPM_MAX_POWER, the device might > generate a spurious PHY event that might cause errors on the link. > Ignore this event if it occurred within 10s after the policy change. > > The timeout was cho

[PATCH] libata: Ignore spurious PHY events on LPM policy change

2015-04-25 Thread Gabriele Mazzotta
When the LPM policy is set to ATA_LPM_MAX_POWER, the device might generate a spurious PHY event that might cause errors on the link. Ignore this event if it occurred within 10s after the policy change. The timeout was chosen observing that on a Dell XPS13 9333 these spurious events can occur up to