Re: [PATCH] libata: fix translation for START STOP UNIT

2007-01-31 Thread Mark Lord
Tejun Heo wrote: A much better solution with thunderbird is using external editor extension. http://globs.org/articles.php?lng=en&pg=2 Brilliant! Installed, and now tested (the max_cmd_len patch posting). -ml - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH] libata: fix translation for START STOP UNIT

2007-01-31 Thread Tejun Heo
Mark Lord wrote: > Robert Hancock wrote: >> I'd love to, but unfortunately nobody seems to have come up with a way >> of doing this in Thunderbird that keeps it from mangling whitespace > > Yup, major nuisance. I have to fire up Kmail whenever I'm posting patches, > and then go back to Thunderbi

Re: [PATCH] libata: fix translation for START STOP UNIT

2007-01-31 Thread Martin J. Bligh
Jeff Garzik wrote: Robert Hancock wrote: Jeff Garzik wrote: * Include the patch inline rather than as an attachment. Even a text/plain attachment is very difficult to review and quote in popular email programs. Jeff I'd love to, but unfortunately nobody seems to have come up with a wa

Re: [PATCH] libata: fix translation for START STOP UNIT

2007-01-30 Thread Mark Lord
Robert Hancock wrote: Jeff Garzik wrote: * Include the patch inline rather than as an attachment. .. I'd love to, but unfortunately nobody seems to have come up with a way of doing this in Thunderbird that keeps it from mangling whitespace Yup, major nuisance. I have to fire up Kmail wh

Re: [PATCH] libata: fix translation for START STOP UNIT

2007-01-30 Thread Jeff Garzik
Robert Hancock wrote: Jeff Garzik wrote: * Include the patch inline rather than as an attachment. Even a text/plain attachment is very difficult to review and quote in popular email programs. Jeff I'd love to, but unfortunately nobody seems to have come up with a way of doing this in

Re: [PATCH] libata: fix translation for START STOP UNIT

2007-01-30 Thread Robert Hancock
Jeff Garzik wrote: * Include the patch inline rather than as an attachment. Even a text/plain attachment is very difficult to review and quote in popular email programs. Jeff I'd love to, but unfortunately nobody seems to have come up with a way of doing this in Thunderbird that keeps

Re: [PATCH] libata: fix translation for START STOP UNIT

2007-01-30 Thread Jeff Garzik
Robert Hancock wrote: Applies to 2.6.20-rc6. --- libata's SCSI translation for the SCSI START STOP UNIT command with the START bit clear (i.e. stopping the drive) appears to be incorrect. It sends an ATA STANDBY command with the time period set to 0, which the code comment says means "now",

[PATCH] libata: fix translation for START STOP UNIT

2007-01-28 Thread Robert Hancock
Applies to 2.6.20-rc6. --- libata's SCSI translation for the SCSI START STOP UNIT command with the START bit clear (i.e. stopping the drive) appears to be incorrect. It sends an ATA STANDBY command with the time period set to 0, which the code comment says means "now", but the ATA standard sa