[PATCH] make /dev/kmem a config option

2008-02-10 Thread Arjan van de Ven
Subject: [PATCH] make /dev/kmem a config option From: Arjan van de Ven <[EMAIL PROTECTED]> This patch makes /dev/kmem a config option; /dev/kmem is VERY rarely used, and when used, it's generally for no good (rootkits tend to be the most common users). With this config option, use

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Arjan van de Ven
On Mon, 11 Feb 2008 01:13:09 +0100 (CET) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Feb 10 2008 15:55, Arjan van de Ven wrote: > >+#ifdef CONFIG_DEVKMEM > > /* > > * This function reads the *virtual* memory as seen by the kernel. > > */ > >@@ -585,6 +588,11 @@ static ssize_t write_kmem(st

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 15:55, Arjan van de Ven wrote: >+#ifdef CONFIG_DEVKMEM > /* > * This function reads the *virtual* memory as seen by the kernel. > */ >@@ -585,6 +588,11 @@ static ssize_t write_kmem(struct file * file, const char >__user * buf, > *ppos = p; > return virtr + wrote; > }

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Arjan van de Ven
> > Is the #else case needed? All kmem_fops uses seem #ifdef'ed out > anyway, except kmem_fops itself. In other words, > > +#ifdef CONFIG_DEVKMEM > static const struct file_operations kmem_fops = { > ... > } > +#endif > > and do away with the three defin

Re: [PATCH] make /dev/kmem a config option

2008-02-11 Thread Arjan van de Ven
On Mon, 11 Feb 2008 14:38:04 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 10 Feb 2008 17:05:09 -0800 > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > Subject: [PATCH] make /dev/kmem a config option > > From: Arjan van de Ven <[EMAIL PROTECTED]&

Re: [PATCH] make /dev/kmem a config option

2008-02-11 Thread Andrew Morton
On Sun, 10 Feb 2008 17:05:09 -0800 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > Subject: [PATCH] make /dev/kmem a config option > From: Arjan van de Ven <[EMAIL PROTECTED]> > > This patch makes /dev/kmem a config option; /dev/kmem is VERY rarely > used, and when used,

Re: [PATCH] make /dev/kmem a config option

2008-02-11 Thread Arjan van de Ven
On Mon, 11 Feb 2008 20:59:14 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 11 Feb 2008 20:03:29 -0800 Arjan van de Ven > <[EMAIL PROTECTED]> wrote: > > > +config DEVKMEM > > + bool "/dev/kmem virtual device support" > > + help > > + Say Y here if you want to support the /dev/km

Re: [PATCH] make /dev/kmem a config option

2008-02-11 Thread Andrew Morton
On Mon, 11 Feb 2008 20:03:29 -0800 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > +config DEVKMEM > + bool "/dev/kmem virtual device support" > + help > + Say Y here if you want to support the /dev/kmem device. The > + /dev/kmem device is rarely used, but can be used for certain