Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-07-28 Thread Ralf Baechle
n wrote: > Date: Mon, 6 Apr 2015 03:51:16 +0200 > From: Bert Vermeulen > To: r...@linux-mips.org, sa...@linux.intel.com, lee.jo...@linaro.org, > linux-m...@linux-mips.org, linux-kernel@vger.kernel.org > Cc: Bert Vermeulen > Subject: [PATCH] mfd: Add support for CPLD chip on M

Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-04-07 Thread Andy Shevchenko
On Tue, Apr 7, 2015 at 6:48 PM, Bert Vermeulen wrote: > On 07/04/15 08:52, Lee Jones wrote: >> On Mon, 06 Apr 2015, Bert Vermeulen wrote: >> >>> The SPI-connected CPLD chip controls access to the main NAND flash >>> chip and five LEDs. >>> >>> Signed-off-by: Bert Vermeulen >>> --- >>> arch/mips

Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-04-07 Thread Bert Vermeulen
On 07/04/15 08:52, Lee Jones wrote: > On Mon, 06 Apr 2015, Bert Vermeulen wrote: > >> The SPI-connected CPLD chip controls access to the main NAND flash >> chip and five LEDs. >> >> Signed-off-by: Bert Vermeulen >> --- >> arch/mips/include/asm/mach-ath79/rb4xx_cpld.h | 49 + >> drivers/mfd

Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-04-06 Thread Lee Jones
On Mon, 06 Apr 2015, Bert Vermeulen wrote: > The SPI-connected CPLD chip controls access to the main NAND flash > chip and five LEDs. > > Signed-off-by: Bert Vermeulen > --- > arch/mips/include/asm/mach-ath79/rb4xx_cpld.h | 49 + > drivers/mfd/Kconfig | 7 + > d

Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-04-06 Thread Bert Vermeulen
Hi Andy, I will submit a new version with your comments addressed. However this one: On 04/06/2015 12:13 PM, Andy Shevchenko wrote: >> +static struct spi_driver rb4xx_cpld_driver = { >> + .probe = rb4xx_cpld_probe, >> + .remove = rb4xx_cpld_remove, >> + .driver = { >> +

Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-04-06 Thread Andy Shevchenko
On Mon, Apr 6, 2015 at 4:51 AM, Bert Vermeulen wrote: > The SPI-connected CPLD chip controls access to the main NAND flash > chip and five LEDs. > Few comments below. > Signed-off-by: Bert Vermeulen > --- > arch/mips/include/asm/mach-ath79/rb4xx_cpld.h | 49 + > drivers/mfd/Kconfig

Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-04-06 Thread Paul Bolle
On Mon, 2015-04-06 at 03:51 +0200, Bert Vermeulen wrote: > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > +config MFD_RB4XX_CPLD > + tristate "MikroTik RB4XX CPLD driver" > + depends on ATH79 && SPI_RB4XX I noticed you also submitted a patch that adds the Kconfig symbol SPI_RB4XX

[PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards

2015-04-05 Thread Bert Vermeulen
The SPI-connected CPLD chip controls access to the main NAND flash chip and five LEDs. Signed-off-by: Bert Vermeulen --- arch/mips/include/asm/mach-ath79/rb4xx_cpld.h | 49 + drivers/mfd/Kconfig | 7 + drivers/mfd/Makefile | 1 + driver