Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-09 Thread Benson Leung
Hi Enric, On Wed, Oct 3, 2018 at 4:01 AM Enric Balletbo i Serra wrote: > > Hi Emil, > > Many thanks to catch this and fix. Some comments below. > > You missed to add the v2, please send the next patch with v3 prefix. > > On 28/9/18 19:08, Emil Karlson wrote: > > Commit

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-09 Thread Benson Leung
Hi Enric, On Wed, Oct 3, 2018 at 4:01 AM Enric Balletbo i Serra wrote: > > Hi Emil, > > Many thanks to catch this and fix. Some comments below. > > You missed to add the v2, please send the next patch with v3 prefix. > > On 28/9/18 19:08, Emil Karlson wrote: > > Commit

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-03 Thread Neil Armstrong
Hi Enric, On 03/10/2018 13:01, Enric Balletbo i Serra wrote: > Hi Emil, > > Many thanks to catch this and fix. Some comments below. > > You missed to add the v2, please send the next patch with v3 prefix. > > On 28/9/18 19:08, Emil Karlson wrote: >> Commit

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-03 Thread Neil Armstrong
Hi Enric, On 03/10/2018 13:01, Enric Balletbo i Serra wrote: > Hi Emil, > > Many thanks to catch this and fix. Some comments below. > > You missed to add the v2, please send the next patch with v3 prefix. > > On 28/9/18 19:08, Emil Karlson wrote: >> Commit

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-03 Thread Enric Balletbo i Serra
Hi Emil, Many thanks to catch this and fix. Some comments below. You missed to add the v2, please send the next patch with v3 prefix. On 28/9/18 19:08, Emil Karlson wrote: > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events > be truncated on many chromebooks so that

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-03 Thread Enric Balletbo i Serra
Hi Emil, Many thanks to catch this and fix. Some comments below. You missed to add the v2, please send the next patch with v3 prefix. On 28/9/18 19:08, Emil Karlson wrote: > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events > be truncated on many chromebooks so that

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-09-28 Thread Emil Karlson
I failed in In-Reply-To: <22cc40a7-015b-6038-2093-8cd1ff0c8...@baylibre.com> somehow. I was urged to go for correct rather than conservative fix on IRC. I have tested this on my message version 0 Kevin and it fixes the original problem for me, but someone should perhaps test this on newer system

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-09-28 Thread Emil Karlson
I failed in In-Reply-To: <22cc40a7-015b-6038-2093-8cd1ff0c8...@baylibre.com> somehow. I was urged to go for correct rather than conservative fix on IRC. I have tested this on my message version 0 Kevin and it fixes the original problem for me, but someone should perhaps test this on newer system

[PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-09-28 Thread Emil Karlson
Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events be truncated on many chromebooks so that Left and Right keys on Column 12 were always 0. Use ret as memcpy len to fix this. drivers/platform/chrome/cros_ec_proto.c:509 get_next_event_xfer uses ret from cros_ec_cmd_xfer

[PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-09-28 Thread Emil Karlson
Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events be truncated on many chromebooks so that Left and Right keys on Column 12 were always 0. Use ret as memcpy len to fix this. drivers/platform/chrome/cros_ec_proto.c:509 get_next_event_xfer uses ret from cros_ec_cmd_xfer