Re: [PATCH] mfd: fix a potential NULL pointer dereference

2019-04-02 Thread Lee Jones
On Mon, 25 Mar 2019, Mukesh Ojha wrote: > On 3/25/2019 1:26 PM, Lee Jones wrote: > > On Fri, 22 Mar 2019, Kangjie Lu wrote: > > > > > Hi Lee Jones, > > > > > > Can you review this patch? > > Don't poke. > > > > I have a very long list of reviews on my TODO. Poking only surfaces > > your patch

Re: [PATCH] mfd: fix a potential NULL pointer dereference

2019-03-25 Thread Mukesh Ojha
On 3/25/2019 1:26 PM, Lee Jones wrote: On Fri, 22 Mar 2019, Kangjie Lu wrote: Hi Lee Jones, Can you review this patch? Don't poke. I have a very long list of reviews on my TODO. Poking only surfaces your patch to the top of my Inbox, and since I review patches in reverse chronological order

Re: [PATCH] mfd: fix a potential NULL pointer dereference

2019-03-25 Thread Lee Jones
On Fri, 22 Mar 2019, Kangjie Lu wrote: > Hi Lee Jones, > > Can you review this patch? Don't poke. I have a very long list of reviews on my TODO. Poking only surfaces your patch to the top of my Inbox, and since I review patches in reverse chronological order, it puts the review to the back of

Re: [PATCH] mfd: fix a potential NULL pointer dereference

2019-03-22 Thread Kangjie Lu
Hi Lee Jones, Can you review this patch? Thanks. > On Mar 9, 2019, at 2:04 AM, Kangjie Lu wrote: > > In case devm_kzalloc fails, the fix does NULL check and returns > -ENOMEM upon failure so as to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu > --- > drivers/mfd/sm501.c | 3

[PATCH] mfd: fix a potential NULL pointer dereference

2019-03-09 Thread Kangjie Lu
In case devm_kzalloc fails, the fix does NULL check and returns -ENOMEM upon failure so as to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/mfd/sm501.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index a530972c5a7e..e01