Re: [PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 09:10:25 + (GMT) Tigran Aivazian <[EMAIL PROTECTED]> wrote: > Hi Jean, > > On Tue, 19 Dec 2006, Jean Delvare wrote: > > I don't see anything in arch/i386/kernel/microcode.c depending on > > CONFIG_HOTPLUG_CPU (in 2.6.20-rc1), sorry. > > I run 2.6.19.1 and there both mc_cp

Re: [PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-19 Thread Tigran Aivazian
Hi Jean, On Tue, 19 Dec 2006, Jean Delvare wrote: I don't see anything in arch/i386/kernel/microcode.c depending on CONFIG_HOTPLUG_CPU (in 2.6.20-rc1), sorry. I run 2.6.19.1 and there both mc_cpu_notifier (which your patch modified) and mc_cpu_callback (which uses mc_cpu_notifier) are inside

Re: [PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-18 Thread Jean Delvare
Hi Tigran, On Mon, 18 Dec 2006 10:04:39 + (GMT), Tigran Aivazian wrote: > Ok, your patch is correct, although I assume you realize that it does > nothing --- both the function and the data it operates on are inside > CONFIG_HOTPLUG_CPU and checking include/linux/init.h I see that > __cpuini

Re: [PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-18 Thread Tigran Aivazian
Hi Jean, Ok, your patch is correct, although I assume you realize that it does nothing --- both the function and the data it operates on are inside CONFIG_HOTPLUG_CPU and checking include/linux/init.h I see that __cpuinitdata is nothing in this case. E.g. msr_class_cpu_notifier in the msr dri

[PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-17 Thread Jean Delvare
Structure mc_cpu_notifier references a __cpuinit function, but isn't declared __cpuinitdata itself: WARNING: arch/i386/kernel/microcode.o - Section mismatch: reference to .init.text: from .data after 'mc_cpu_notifier' (at offset 0x118) Signed-off-by: Jean Delvare <[EMAIL PROTECTED]> --- arch/i38