Re: [RESEND PATCH] mm/hotplug: fix notification in offline error path

2019-03-22 Thread Michal Hocko
On Fri 22-03-19 12:20:12, Souptick Joarder wrote: > On Thu, Mar 21, 2019 at 2:13 AM Qian Cai wrote: > > > > When start_isolate_page_range() returned -EBUSY in __offline_pages(), it > > calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized > > "arg". As the result, it triggers warning

Re: [RESEND PATCH] mm/hotplug: fix notification in offline error path

2019-03-21 Thread Souptick Joarder
On Thu, Mar 21, 2019 at 2:13 AM Qian Cai wrote: > > When start_isolate_page_range() returned -EBUSY in __offline_pages(), it > calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized > "arg". As the result, it triggers warnings below. Also, it is only > necessary to notify MEM_CANCEL_O

[RESEND PATCH] mm/hotplug: fix notification in offline error path

2019-03-20 Thread Qian Cai
When start_isolate_page_range() returned -EBUSY in __offline_pages(), it calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized "arg". As the result, it triggers warnings below. Also, it is only necessary to notify MEM_CANCEL_OFFLINE after MEM_GOING_OFFLINE. page:ea000120 coun

Re: [PATCH] mm/hotplug: fix notification in offline error path

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 05:09:39PM -0400, Qian Cai wrote: > Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining > failure") > Signed-off-by: Qian Cai Reviewed-by: Oscar Salvador > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] mm/hotplug: fix notification in offline error path

2019-03-13 Thread Michal Hocko
On Wed 13-03-19 17:09:39, Qian Cai wrote: > When start_isolate_page_range() returned -EBUSY in __offline_pages(), it > calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized > "arg". As the result, it triggers warnings below. Also, it is only > necessary to notify MEM_CANCEL_OFFLINE af

[PATCH] mm/hotplug: fix notification in offline error path

2019-03-13 Thread Qian Cai
When start_isolate_page_range() returned -EBUSY in __offline_pages(), it calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized "arg". As the result, it triggers warnings below. Also, it is only necessary to notify MEM_CANCEL_OFFLINE after MEM_GOING_OFFLINE. page:ea000120 coun