Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-06-02 Thread Wei Yang
On Fri, Jun 02, 2017 at 10:26:06AM +0800, zhong jiang wrote: >On 2017/6/2 9:45, Wei Yang wrote: >> On Fri, May 26, 2017 at 09:55:31AM +0800, zhong jiang wrote: >>> On 2017/5/26 9:36, Wei Yang wrote: On Thu, May 25, 2017 at 11:04:44AM +0800, zhong jiang wrote: > I hit the overlap issue, but

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-06-01 Thread zhong jiang
On 2017/6/2 9:45, Wei Yang wrote: > On Fri, May 26, 2017 at 09:55:31AM +0800, zhong jiang wrote: >> On 2017/5/26 9:36, Wei Yang wrote: >>> On Thu, May 25, 2017 at 11:04:44AM +0800, zhong jiang wrote: I hit the overlap issue, but it is hard to reproduced. if you think it is safe. and the

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-06-01 Thread Wei Yang
On Fri, May 26, 2017 at 09:55:31AM +0800, zhong jiang wrote: >On 2017/5/26 9:36, Wei Yang wrote: >> On Thu, May 25, 2017 at 11:04:44AM +0800, zhong jiang wrote: >>> I hit the overlap issue, but it is hard to reproduced. if you think it is >>> safe. and the situation >>> is not happen. AFAIC, it i

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-05-25 Thread zhong jiang
On 2017/5/26 9:36, Wei Yang wrote: > On Thu, May 25, 2017 at 11:04:44AM +0800, zhong jiang wrote: >> I hit the overlap issue, but it is hard to reproduced. if you think it is >> safe. and the situation >> is not happen. AFAIC, it is no need to add the code. >> >> if you insist on the point. Maybe

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-05-25 Thread Wei Yang
On Thu, May 25, 2017 at 11:04:44AM +0800, zhong jiang wrote: >I hit the overlap issue, but it is hard to reproduced. if you think it is >safe. and the situation >is not happen. AFAIC, it is no need to add the code. > >if you insist on the point. Maybe VM_WARN_ON is a choice. > Do you have some l

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-05-24 Thread Michal Hocko
On Wed 24-05-17 23:07:30, Wei Yang wrote: > On Wed, May 24, 2017 at 02:11:35PM +0200, Michal Hocko wrote: > >On Wed 24-05-17 18:03:47, Wei Yang wrote: > >> The vmap RB tree store the elements in order and no overlap between any of > >> them. The comparison in __insert_vmap_area() is to decide which

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-05-24 Thread zhong jiang
I hit the overlap issue, but it is hard to reproduced. if you think it is safe. and the situation is not happen. AFAIC, it is no need to add the code. if you insist on the point. Maybe VM_WARN_ON is a choice. Regards zhongjiang On 2017/5/24 18:03, Wei Yang wrote: > The vmap RB tree store the el

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-05-24 Thread Wei Yang
On Wed, May 24, 2017 at 02:11:35PM +0200, Michal Hocko wrote: >On Wed 24-05-17 18:03:47, Wei Yang wrote: >> The vmap RB tree store the elements in order and no overlap between any of >> them. The comparison in __insert_vmap_area() is to decide which direction >> the search should follow and make su

Re: [PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-05-24 Thread Michal Hocko
On Wed 24-05-17 18:03:47, Wei Yang wrote: > The vmap RB tree store the elements in order and no overlap between any of > them. The comparison in __insert_vmap_area() is to decide which direction > the search should follow and make sure the new vmap_area is not overlap > with any other. > > Current

[PATCH] mm/vmalloc: a slight change of compare target in __insert_vmap_area()

2017-05-24 Thread Wei Yang
The vmap RB tree store the elements in order and no overlap between any of them. The comparison in __insert_vmap_area() is to decide which direction the search should follow and make sure the new vmap_area is not overlap with any other. Current implementation fails to do the overlap check. When f