Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-23 Thread Minchan Kim
On Fri, Dec 21, 2012 at 01:46:23PM +0100, Michal Nazarewicz wrote: > > On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote: > >> Perhaps “is_migrate_isolate” to match already existing “is_migrate_cma”? > > On Fri, Dec 21 2012, Minchan Kim wrote: > > Good poking. In fact, while I

Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-23 Thread Minchan Kim
On Fri, Dec 21, 2012 at 01:46:23PM +0100, Michal Nazarewicz wrote: On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote: Perhaps “is_migrate_isolate” to match already existing “is_migrate_cma”? On Fri, Dec 21 2012, Minchan Kim wrote: Good poking. In fact, while I made this

Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-21 Thread Michal Nazarewicz
> On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote: >> Perhaps “is_migrate_isolate” to match already existing “is_migrate_cma”? On Fri, Dec 21 2012, Minchan Kim wrote: > Good poking. In fact, while I made this patch, I was very tempted by renaming > is_migrate_cma to

Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-21 Thread Michal Nazarewicz
On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote: Perhaps “is_migrate_isolate” to match already existing “is_migrate_cma”? On Fri, Dec 21 2012, Minchan Kim wrote: Good poking. In fact, while I made this patch, I was very tempted by renaming is_migrate_cma to cma_pageblock.

Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-20 Thread Minchan Kim
On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote: > On Thu, Dec 20 2012, Minchan Kim wrote: > > diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h > > index a92061e..4ada4ef 100644 > > --- a/include/linux/page-isolation.h > > +++

Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-20 Thread Michal Nazarewicz
On Thu, Dec 20 2012, Minchan Kim wrote: > diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h > index a92061e..4ada4ef 100644 > --- a/include/linux/page-isolation.h > +++ b/include/linux/page-isolation.h > @@ -1,6 +1,25 @@ > #ifndef __LINUX_PAGEISOLATION_H > #define

Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-20 Thread Michal Nazarewicz
On Thu, Dec 20 2012, Minchan Kim wrote: diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h index a92061e..4ada4ef 100644 --- a/include/linux/page-isolation.h +++ b/include/linux/page-isolation.h @@ -1,6 +1,25 @@ #ifndef __LINUX_PAGEISOLATION_H #define

Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-20 Thread Minchan Kim
On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote: On Thu, Dec 20 2012, Minchan Kim wrote: diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h index a92061e..4ada4ef 100644 --- a/include/linux/page-isolation.h +++ b/include/linux/page-isolation.h

[PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-19 Thread Minchan Kim
Now mm several functions test MIGRATE_ISOLATE and some of those are hotpath but MIGRATE_ISOLATE is used only if we enable CONFIG_MEMORY_ISOLATION(ie, CMA, memory-hotplug and memory-failure) which are not common config option. So let's not add unnecessary overhead and code. Signed-off-by: Minchan

[PATCH] mm: compare MIGRATE_ISOLATE selectively

2012-12-19 Thread Minchan Kim
Now mm several functions test MIGRATE_ISOLATE and some of those are hotpath but MIGRATE_ISOLATE is used only if we enable CONFIG_MEMORY_ISOLATION(ie, CMA, memory-hotplug and memory-failure) which are not common config option. So let's not add unnecessary overhead and code. Signed-off-by: Minchan