Re: [PATCH] mm: filemap: clear idle flag for writes

On 6/24/20 12:50 PM, Shakeel Butt wrote: On Wed, Jun 24, 2020 at 12:18 PM Yang Shi wrote: On 6/24/20 11:53 AM, Andrew Morton wrote: On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi wrote: Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: only do access activations on

Re: [PATCH] mm: filemap: clear idle flag for writes

On Wed, Jun 24, 2020 at 12:18 PM Yang Shi wrote: > > > > On 6/24/20 11:53 AM, Andrew Morton wrote: > > On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi > > wrote: > > > >> Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > >> only do access activations on reads"),

Re: [PATCH] mm: filemap: clear idle flag for writes

On Wed, Jun 24, 2020 at 10:43 AM Yang Shi wrote: > > Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > only do access activations on reads"), mark_page_accessed() is called > for reads only. But the idle flag is cleared by mark_page_accessed() so > the idle flag won't get

Re: [PATCH] mm: filemap: clear idle flag for writes

On 6/24/20 11:53 AM, Andrew Morton wrote: On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi wrote: Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: only do access activations on reads"), mark_page_accessed() is called for reads only. But the idle flag is cleared by

Re: [PATCH] mm: filemap: clear idle flag for writes

On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi wrote: > Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > only do access activations on reads"), mark_page_accessed() is called > for reads only. But the idle flag is cleared by mark_page_accessed() so > the idle flag won't get

[PATCH] mm: filemap: clear idle flag for writes

Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: only do access activations on reads"), mark_page_accessed() is called for reads only. But the idle flag is cleared by mark_page_accessed() so the idle flag won't get cleared if the page is write accessed only. Basically idle