Re: [External] Re: [PATCH] mm: memcontrol: fix memsw uncharge for root_mem_cgroup

2021-03-24 Thread Michal Hocko
On Wed 24-03-21 16:50:41, Muchun Song wrote: > On Wed, Mar 24, 2021 at 4:33 PM Michal Hocko wrote: > > > > On Wed 24-03-21 12:11:35, Muchun Song wrote: > > > On Tue, Mar 23, 2021 at 11:04 PM Muchun Song > > > wrote: > > > > > > > > The pages aren't accounted at the root level, so we cannot uncha

Re: [External] Re: [PATCH] mm: memcontrol: fix memsw uncharge for root_mem_cgroup

2021-03-24 Thread Muchun Song
On Wed, Mar 24, 2021 at 4:33 PM Michal Hocko wrote: > > On Wed 24-03-21 12:11:35, Muchun Song wrote: > > On Tue, Mar 23, 2021 at 11:04 PM Muchun Song > > wrote: > > > > > > The pages aren't accounted at the root level, so we cannot uncharge the > > > page to the memsw counter for the root memcg.

Re: [PATCH] mm: memcontrol: fix memsw uncharge for root_mem_cgroup

2021-03-24 Thread Michal Hocko
On Wed 24-03-21 12:11:35, Muchun Song wrote: > On Tue, Mar 23, 2021 at 11:04 PM Muchun Song wrote: > > > > The pages aren't accounted at the root level, so we cannot uncharge the > > page to the memsw counter for the root memcg. Fix this. > > > > Fixes: 1f47b61fb407 ("mm: memcontrol: fix swap coun

Re: [PATCH] mm: memcontrol: fix memsw uncharge for root_mem_cgroup

2021-03-23 Thread Muchun Song
On Tue, Mar 23, 2021 at 11:04 PM Muchun Song wrote: > > The pages aren't accounted at the root level, so we cannot uncharge the > page to the memsw counter for the root memcg. Fix this. > > Fixes: 1f47b61fb407 ("mm: memcontrol: fix swap counter leak on swapout from > offline cgroup") > Signed-off

Re: [PATCH] mm: memcontrol: fix memsw uncharge for root_mem_cgroup

2021-03-23 Thread Michal Hocko
On Tue 23-03-21 22:56:53, Muchun Song wrote: > The pages aren't accounted at the root level, so we cannot uncharge the > page to the memsw counter for the root memcg. Fix this. The patch is correct but I do wonder whether this matters much in the end. We shouldn't really rely on a correct page cou

[PATCH] mm: memcontrol: fix memsw uncharge for root_mem_cgroup

2021-03-23 Thread Muchun Song
The pages aren't accounted at the root level, so we cannot uncharge the page to the memsw counter for the root memcg. Fix this. Fixes: 1f47b61fb407 ("mm: memcontrol: fix swap counter leak on swapout from offline cgroup") Signed-off-by: Muchun Song --- mm/memcontrol.c | 3 ++- 1 file changed, 2