Re: [PATCH] mtd: nand: Use ULL-suffix for big u64 constant

2014-08-11 Thread Geert Uytterhoeven
Hi Brian, On Mon, Aug 11, 2014 at 9:06 PM, Brian Norris wrote: > I'm curious: do your broken compilers also generate broken code/data? > i.e., does gcc 4.4.7 give 2500 its proper ULL value still? Yes it does (checked the assembler output). >> > However, I could be convinced to apply thi

Re: [PATCH] mtd: nand: Use ULL-suffix for big u64 constant

2014-08-11 Thread Brian Norris
On Mon, Aug 11, 2014 at 08:51:51PM +0200, Geert Uytterhoeven wrote: > On Mon, Aug 11, 2014 at 7:50 PM, Brian Norris > wrote: > > On Sat, Aug 09, 2014 at 07:07:53PM +0200, Geert Uytterhoeven wrote: > >> drivers/mtd/nand/nand_timings.c:45: warning: integer constant is too large > >> for ‘long’ type

Re: [PATCH] mtd: nand: Use ULL-suffix for big u64 constant

2014-08-11 Thread Geert Uytterhoeven
Hi Brian, On Mon, Aug 11, 2014 at 7:50 PM, Brian Norris wrote: > On Sat, Aug 09, 2014 at 07:07:53PM +0200, Geert Uytterhoeven wrote: >> drivers/mtd/nand/nand_timings.c:45: warning: integer constant is too large >> for ‘long’ type > > On what compiler / static analyzer? Any 32-bit version of gcc

Re: [PATCH] mtd: nand: Use ULL-suffix for big u64 constant

2014-08-11 Thread Brian Norris
On Sat, Aug 09, 2014 at 07:07:53PM +0200, Geert Uytterhoeven wrote: > drivers/mtd/nand/nand_timings.c:45: warning: integer constant is too large > for ‘long’ type On what compiler / static analyzer? > Signed-off-by: Geert Uytterhoeven > --- > drivers/mtd/nand/nand_timings.c | 2 +- > 1 file ch

[PATCH] mtd: nand: Use ULL-suffix for big u64 constant

2014-08-09 Thread Geert Uytterhoeven
drivers/mtd/nand/nand_timings.c:45: warning: integer constant is too large for ‘long’ type Signed-off-by: Geert Uytterhoeven --- drivers/mtd/nand/nand_timings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c