Re: [PATCH] mutex: fix deadlock injection

2013-08-06 Thread Maarten Lankhorst
Op 07-08-13 02:05, Dave Airlie schreef: > On Tue, Jul 30, 2013 at 6:41 PM, Peter Zijlstra wrote: >> On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: >>> The check needs to be for > 1, because ctx->acquired is already incremented. >>> This will prevent ww_mutex_lock_slow from retu

Re: [PATCH] mutex: fix deadlock injection

2013-08-06 Thread Dave Airlie
On Tue, Jul 30, 2013 at 6:41 PM, Peter Zijlstra wrote: > On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: >> The check needs to be for > 1, because ctx->acquired is already incremented. >> This will prevent ww_mutex_lock_slow from returning -EDEADLK and not locking >> the mutex.

Re: [PATCH] mutex: fix deadlock injection

2013-08-05 Thread Daniel Vetter
On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: > The check needs to be for > 1, because ctx->acquired is already incremented. > This will prevent ww_mutex_lock_slow from returning -EDEADLK and not locking > the mutex. It caused a lot of false gpu lockups on radeon with > CONFIG_

Re: [PATCH] mutex: fix deadlock injection

2013-07-30 Thread Alex Deucher
On Tue, Jul 30, 2013 at 4:13 AM, Maarten Lankhorst wrote: > The check needs to be for > 1, because ctx->acquired is already incremented. > This will prevent ww_mutex_lock_slow from returning -EDEADLK and not locking > the mutex. It caused a lot of false gpu lockups on radeon with > CONFIG_DEBUG_WW

Re: [PATCH] mutex: fix deadlock injection

2013-07-30 Thread Peter Zijlstra
On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: > The check needs to be for > 1, because ctx->acquired is already incremented. > This will prevent ww_mutex_lock_slow from returning -EDEADLK and not locking > the mutex. It caused a lot of false gpu lockups on radeon with > CONFIG_

[PATCH] mutex: fix deadlock injection

2013-07-30 Thread Maarten Lankhorst
The check needs to be for > 1, because ctx->acquired is already incremented. This will prevent ww_mutex_lock_slow from returning -EDEADLK and not locking the mutex. It caused a lot of false gpu lockups on radeon with CONFIG_DEBUG_WW_MUTEX_SLOWPATH=y because a function that shouldn't be able to retu