Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-20 Thread Peter Hurley
On 01/20/2015 01:39 PM, Howard Chu wrote: > Peter Hurley wrote: >> On 01/19/2015 02:43 PM, Howard Chu wrote: [...] >> So it's really back to the question of, does allowing EXTPROC for regular >> ttys have _value_? > > Does preventing it have value? Not that that is the appropriate metric for ke

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-20 Thread Howard Chu
Howard Chu wrote: Peter Hurley wrote: On 01/19/2015 02:43 PM, Howard Chu wrote: The fact that EXTPROC can be manually unset is by design. Quoting from the original again: stty.diff: This file contains the changes needed for the stty(1) program to report on the current status of the

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-20 Thread Howard Chu
Peter Hurley wrote: On 01/19/2015 02:43 PM, Howard Chu wrote: The fact that EXTPROC can be manually unset is by design. Quoting from the original again: stty.diff: This file contains the changes needed for the stty(1) program to report on the current status of the TS_EXTPROC bit. I

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-20 Thread Peter Hurley
On 01/19/2015 02:43 PM, Howard Chu wrote: > Peter Hurley wrote: >> On 01/19/2015 11:36 AM, Howard Chu wrote: >>> Peter Hurley wrote: [...] Which brings up another point: only a pty master should be able to set EXTPROC mode. Right now, any tty can be set to EXTPROC and the pty slav

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-20 Thread Peter Hurley
On 01/19/2015 02:43 PM, Howard Chu wrote: > Peter Hurley wrote: >> On 01/19/2015 11:36 AM, Howard Chu wrote: >>> Peter Hurley wrote: On 01/19/2015 07:46 AM, Howard Chu wrote: > Peter Hurley wrote: [...] Which brings up another point: only a pty master should be able to set EXT

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-20 Thread Peter Hurley
On 01/20/2015 09:53 AM, Peter Hurley wrote: > On 01/19/2015 03:31 PM, Howard Chu wrote: >> Peter Hurley wrote: >>> Ok. >>> I might see if I can get telnet + a revised kernel interface to work >>> together; I'll >>> let you know if this works out. >> >> The patch here https://bugs.debian.org/cgi-bi

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-20 Thread Peter Hurley
On 01/19/2015 03:31 PM, Howard Chu wrote: > Peter Hurley wrote: >> Ok. >> I might see if I can get telnet + a revised kernel interface to work >> together; I'll >> let you know if this works out. > > The patch here https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585527#20 > still applies clean

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Howard Chu
Peter Hurley wrote: Ok. I might see if I can get telnet + a revised kernel interface to work together; I'll let you know if this works out. The patch here https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585527#20 still applies cleanly to current Ubuntu netkit-telnet source and works. You

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Howard Chu
Peter Hurley wrote: On 01/19/2015 11:36 AM, Howard Chu wrote: Peter Hurley wrote: Thanks, Howard. [ adding Ted too ] On 01/19/2015 07:46 AM, Howard Chu wrote: Peter Hurley wrote: On 01/18/2015 05:45 PM, Howard Chu wrote: Peter Hurley wrote: Commit 26df6d13406d1 ("tty: Add EXTPROC support

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Peter Hurley
On 01/19/2015 11:36 AM, Howard Chu wrote: > Peter Hurley wrote: [...] >> A description of how the pty master uses EXTPROC to implement line mode would >> be very helpful, especially to people working in the tty code (eg., me, >> although >> I don't need it now). > > The original patch submissio

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Peter Hurley
On 01/19/2015 11:36 AM, Howard Chu wrote: > Peter Hurley wrote: >> Thanks, Howard. >> >> [ adding Ted too ] >> >> On 01/19/2015 07:46 AM, Howard Chu wrote: >>> Peter Hurley wrote: On 01/18/2015 05:45 PM, Howard Chu wrote: > Peter Hurley wrote: >> Commit 26df6d13406d1 ("tty: Add EXTPROC

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Peter Hurley
On 01/19/2015 11:37 AM, Theodore Ts'o wrote: > On Mon, Jan 19, 2015 at 09:57:23AM -0500, Peter Hurley wrote: >> >> This reader set EOL2 to DISABLED_CHAR earlier, and left EOL unchanged. >> I have seen userspace code that expects a line to be no longer than 4096 >> chars. > > Userspace code that d

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Theodore Ts'o
On Mon, Jan 19, 2015 at 09:57:23AM -0500, Peter Hurley wrote: > > This reader set EOL2 to DISABLED_CHAR earlier, and left EOL unchanged. > I have seen userspace code that expects a line to be no longer than 4096 > chars. Userspace code that does this is going to be very fragile. Input from the

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Howard Chu
Peter Hurley wrote: Thanks, Howard. [ adding Ted too ] On 01/19/2015 07:46 AM, Howard Chu wrote: Peter Hurley wrote: On 01/18/2015 05:45 PM, Howard Chu wrote: Peter Hurley wrote: Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added the undocumented EXTPROC input processing m

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Peter Hurley
Hi Ted, On 01/18/2015 11:55 PM, Theodore Ts'o wrote: > Line mode goes back to BSD 4.x days, and it's useful over high latency > links --- i.e., the sort of thing that you get with stone age cellular > data networks (i.e., the sort of thing that we still have the US), > amateur packet radio links,

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Peter Hurley
Thanks, Howard. [ adding Ted too ] On 01/19/2015 07:46 AM, Howard Chu wrote: > Peter Hurley wrote: >> On 01/18/2015 05:45 PM, Howard Chu wrote: >>> Peter Hurley wrote: Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added the undocumented EXTPROC input processing mode, wh

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-19 Thread Howard Chu
Peter Hurley wrote: On 01/18/2015 05:45 PM, Howard Chu wrote: Peter Hurley wrote: Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added the undocumented EXTPROC input processing mode, which ignores the ICANON setting and forces pty slave input to be processed in non-canonical mod

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-18 Thread Theodore Ts'o
Line mode goes back to BSD 4.x days, and it's useful over high latency links --- i.e., the sort of thing that you get with stone age cellular data networks (i.e., the sort of thing that we still have the US), amateur packet radio links, etc. So it's certianly a nice to have, if someone is willing

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-18 Thread Peter Hurley
On 01/18/2015 05:44 PM, Howard Chu wrote: > Peter Hurley wrote: >> Hi Howard, >> >> On 01/18/2015 05:09 PM, Howard Chu wrote: >>> Peter Hurley wrote: Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added the undocumented EXTPROC input processing mode, which ignores the ICAN

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-18 Thread Howard Chu
Peter Hurley wrote: Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added the undocumented EXTPROC input processing mode, which ignores the ICANON setting and forces pty slave input to be processed in non-canonical mode. Although intended to provide a transparent mechanism for loc

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-18 Thread Howard Chu
Peter Hurley wrote: Hi Howard, On 01/18/2015 05:09 PM, Howard Chu wrote: Peter Hurley wrote: Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added the undocumented EXTPROC input processing mode, which ignores the ICANON setting and forces pty slave input to be processed in non-c

Re: [PATCH] n_tty: Remove LINEMODE support

2015-01-18 Thread Peter Hurley
Hi Howard, On 01/18/2015 05:09 PM, Howard Chu wrote: > Peter Hurley wrote: >> Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added >> the undocumented EXTPROC input processing mode, which ignores the ICANON >> setting and forces pty slave input to be processed in non-canonical >> m

[PATCH] n_tty: Remove LINEMODE support

2015-01-18 Thread Peter Hurley
Commit 26df6d13406d1 ("tty: Add EXTPROC support for LINEMODE") added the undocumented EXTPROC input processing mode, which ignores the ICANON setting and forces pty slave input to be processed in non-canonical mode. Although intended to provide a transparent mechanism for local line edit with teln