Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-07-01 Thread Colin Ian King
On 01/07/2019 23:43, Martin Blumenstingl wrote: > On Fri, Jun 28, 2019 at 6:05 PM Martin Blumenstingl > wrote: >> >> Hi Colin, >> >> On Fri, Jun 28, 2019 at 10:32 AM Colin Ian King >> wrote: >>> >>> On 28/06/2019 05:15, Martin Blumenstingl wrote: On Tue, Jun 25, 2019 at 9:58 AM Colin Ian Kin

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-07-01 Thread Martin Blumenstingl
On Fri, Jun 28, 2019 at 6:05 PM Martin Blumenstingl wrote: > > Hi Colin, > > On Fri, Jun 28, 2019 at 10:32 AM Colin Ian King > wrote: > > > > On 28/06/2019 05:15, Martin Blumenstingl wrote: > > > On Tue, Jun 25, 2019 at 9:58 AM Colin Ian King > > > wrote: > > >> > > >> On 25/06/2019 05:44, Mart

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-28 Thread Martin Blumenstingl
Hi Colin, On Fri, Jun 28, 2019 at 10:32 AM Colin Ian King wrote: > > On 28/06/2019 05:15, Martin Blumenstingl wrote: > > On Tue, Jun 25, 2019 at 9:58 AM Colin Ian King > > wrote: > >> > >> On 25/06/2019 05:44, Martin Blumenstingl wrote: > >>> Hi Colin, > >>> > >>> On Thu, Jun 20, 2019 at 3:34 A

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-28 Thread Colin Ian King
On 28/06/2019 05:15, Martin Blumenstingl wrote: > On Tue, Jun 25, 2019 at 9:58 AM Colin Ian King > wrote: >> >> On 25/06/2019 05:44, Martin Blumenstingl wrote: >>> Hi Colin, >>> >>> On Thu, Jun 20, 2019 at 3:34 AM Martin Blumenstingl >>> wrote: Hi Colin, On Wed, Jun 19, 2019

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-27 Thread Martin Blumenstingl
On Tue, Jun 25, 2019 at 9:58 AM Colin Ian King wrote: > > On 25/06/2019 05:44, Martin Blumenstingl wrote: > > Hi Colin, > > > > On Thu, Jun 20, 2019 at 3:34 AM Martin Blumenstingl > > wrote: > >> > >> Hi Colin, > >> > >> On Wed, Jun 19, 2019 at 8:55 AM Colin Ian King > >> wrote: > >>> > >>> On

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-25 Thread Colin Ian King
On 25/06/2019 05:44, Martin Blumenstingl wrote: > Hi Colin, > > On Thu, Jun 20, 2019 at 3:34 AM Martin Blumenstingl > wrote: >> >> Hi Colin, >> >> On Wed, Jun 19, 2019 at 8:55 AM Colin Ian King >> wrote: >>> >>> On 19/06/2019 06:13, Martin Blumenstingl wrote: Hi Colin, > Currently

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-24 Thread Martin Blumenstingl
Hi Colin, On Thu, Jun 20, 2019 at 3:34 AM Martin Blumenstingl wrote: > > Hi Colin, > > On Wed, Jun 19, 2019 at 8:55 AM Colin Ian King > wrote: > > > > On 19/06/2019 06:13, Martin Blumenstingl wrote: > > > Hi Colin, > > > > > >> Currently the call to device_property_read_u32_array is not error c

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-19 Thread Martin Blumenstingl
Hi Colin, On Wed, Jun 19, 2019 at 8:55 AM Colin Ian King wrote: > > On 19/06/2019 06:13, Martin Blumenstingl wrote: > > Hi Colin, > > > >> Currently the call to device_property_read_u32_array is not error checked > >> leading to potential garbage values in the delays array that are then used > >>

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-18 Thread Colin Ian King
On 19/06/2019 06:13, Martin Blumenstingl wrote: > Hi Colin, > >> Currently the call to device_property_read_u32_array is not error checked >> leading to potential garbage values in the delays array that are then used >> in msleep delays. Add a sanity check to the property fetching. >> >> Addresse

RE: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-18 Thread Martin Blumenstingl
Hi Colin, > Currently the call to device_property_read_u32_array is not error checked > leading to potential garbage values in the delays array that are then used > in msleep delays. Add a sanity check to the property fetching. > > Addresses-Coverity: ("Uninitialized scalar variable") > Signed-o

Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-18 Thread David Miller
From: Colin King Date: Mon, 17 Jun 2019 17:58:36 +0100 > From: Colin Ian King > > Currently the call to device_property_read_u32_array is not error checked > leading to potential garbage values in the delays array that are then used > in msleep delays. Add a sanity check to the property fetchi

[PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-17 Thread Colin King
From: Colin Ian King Currently the call to device_property_read_u32_array is not error checked leading to potential garbage values in the delays array that are then used in msleep delays. Add a sanity check to the property fetching. Addresses-Coverity: ("Uninitialized scalar variable") Signed-o