Re: [PATCH] netdev: Fix sleeping inside wait event

2014-10-29 Thread David Miller
From: Peter Zijlstra Date: Wed, 29 Oct 2014 18:31:10 +0100 > On Wed, Oct 29, 2014 at 06:13:45PM +0100, Peter Zijlstra wrote: >> On Wed, Oct 29, 2014 at 09:29:55AM -0700, Cong Wang wrote: >> > While you are on it, please fix rtnl_lock_unregistering_all() too? >> >> Ah, that's hidden someplace els

Re: [PATCH] netdev: Fix sleeping inside wait event

2014-10-29 Thread David Miller
From: Peter Zijlstra Date: Wed, 29 Oct 2014 17:16:57 +0100 > On Tue, Oct 28, 2014 at 10:25:41PM +0800, Fengguang Wu wrote: >> [ 122.247299] [ cut here ] >> [ 122.247328] WARNING: CPU: 0 PID: 61 at kernel/sched/core.c:7312 >> __might_sleep+0x50/0x249() >> [ 122.247334]

Re: [PATCH] netdev: Fix sleeping inside wait event

2014-10-29 Thread Peter Zijlstra
On Wed, Oct 29, 2014 at 06:13:45PM +0100, Peter Zijlstra wrote: > On Wed, Oct 29, 2014 at 09:29:55AM -0700, Cong Wang wrote: > > While you are on it, please fix rtnl_lock_unregistering_all() too? > > Ah, that's hidden someplace else, sure I can do that. Thanks for > pointing it out. Here goes..

Re: [PATCH] netdev: Fix sleeping inside wait event

2014-10-29 Thread Peter Zijlstra
On Wed, Oct 29, 2014 at 09:29:55AM -0700, Cong Wang wrote: > (Adding netdev@...) > > On Wed, Oct 29, 2014 at 9:16 AM, Peter Zijlstra wrote: > > > > Dave, this relies on bits currently in tip/sched/core, if you're ok I'll > > merge it through that tree. > > > > --- > > Subject: netdev: Fix sleepin

Re: [PATCH] netdev: Fix sleeping inside wait event

2014-10-29 Thread Cong Wang
(Adding netdev@...) On Wed, Oct 29, 2014 at 9:16 AM, Peter Zijlstra wrote: > > Dave, this relies on bits currently in tip/sched/core, if you're ok I'll > merge it through that tree. > > --- > Subject: netdev: Fix sleeping inside wait event > From: Peter Zijlstra > Date: Wed Oct 29 17:04:56 CET 2

[PATCH] netdev: Fix sleeping inside wait event

2014-10-29 Thread Peter Zijlstra
On Tue, Oct 28, 2014 at 10:25:41PM +0800, Fengguang Wu wrote: > [ 122.247299] [ cut here ] > [ 122.247328] WARNING: CPU: 0 PID: 61 at kernel/sched/core.c:7312 > __might_sleep+0x50/0x249() > [ 122.247334] do not call blocking ops when !TASK_RUNNING; state=2 set at > [] p