Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-16 Thread Rajendra Nayak
On 8/13/2020 9:59 AM, Viresh Kumar wrote: On 11-08-20, 14:09, Stephen Boyd wrote: This is a goto maze! Any chance we can clean this up? I have sent a short series in reply to this series, please have a look. It should look better now. Thanks, I was out a few days so could not get to the

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-12 Thread Viresh Kumar
On 11-08-20, 14:09, Stephen Boyd wrote: > This is a goto maze! Any chance we can clean this up? I have sent a short series in reply to this series, please have a look. It should look better now. -- viresh

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-11 Thread Rajendra Nayak
On 8/11/2020 10:42 PM, Matthias Kaehlcke wrote: On Mon, Aug 10, 2020 at 12:36:19PM +0530, Rajendra Nayak wrote: dev_pm_opp_set_rate() can now be called with freq = 0 inorder to either drop performance or bandwidth votes or to disable regulators on platforms which support them. In such cases,

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-11 Thread Stephen Boyd
Quoting Rajendra Nayak (2020-08-10 00:06:19) > dev_pm_opp_set_rate() can now be called with freq = 0 inorder > to either drop performance or bandwidth votes or to disable > regulators on platforms which support them. > In such cases, a subsequent call to dev_pm_opp_set_rate() with > the same

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-11 Thread Matthias Kaehlcke
On Mon, Aug 10, 2020 at 12:36:19PM +0530, Rajendra Nayak wrote: > dev_pm_opp_set_rate() can now be called with freq = 0 inorder > to either drop performance or bandwidth votes or to disable > regulators on platforms which support them. > In such cases, a subsequent call to dev_pm_opp_set_rate()

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-10 Thread Sibi Sankar
On 2020-08-10 12:36, Rajendra Nayak wrote: dev_pm_opp_set_rate() can now be called with freq = 0 inorder to either drop performance or bandwidth votes or to disable regulators on platforms which support them. In such cases, a subsequent call to dev_pm_opp_set_rate() with the same frequency ends

[PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-10 Thread Rajendra Nayak
dev_pm_opp_set_rate() can now be called with freq = 0 inorder to either drop performance or bandwidth votes or to disable regulators on platforms which support them. In such cases, a subsequent call to dev_pm_opp_set_rate() with the same frequency ends up returning early because 'old_freq == freq'