Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-23 Thread Ondrej Zary
On Monday 23 September 2013 15:00:42 Tejun Heo wrote: > On Mon, Sep 23, 2013 at 04:51:16PM +0400, Sergei Shtylyov wrote: > > >Applied to libata/for-3.13. > > > >Why only 3.13? Isn't it a simple fix? > > Hmmm, maybe, the driver is such low impact, I don't think it matters > either way; otherwise

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-23 Thread Tejun Heo
On Mon, Sep 23, 2013 at 04:51:16PM +0400, Sergei Shtylyov wrote: > >Applied to libata/for-3.13. > >Why only 3.13? Isn't it a simple fix? Hmmm, maybe, the driver is such low impact, I don't think it matters either way; otherwise, it should be marked -stable too. It's a driver which shouldn't

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-23 Thread Sergei Shtylyov
Hello. On 23-09-2013 1:42, Tejun Heo wrote: The test for 2nd I/O port validity is broken (reversed): On devices with no control port, the driver attempts to use invalid port 0, resulting in logs full of bad_io_access errors. On devices with control port, the driver does not use it. Signed-of

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-22 Thread Tejun Heo
On Thu, Sep 12, 2013 at 11:01:29PM +0200, Ondrej Zary wrote: > The test for 2nd I/O port validity is broken (reversed): > On devices with no control port, the driver attempts to use invalid port 0, > resulting in logs full of bad_io_access errors. > On devices with control port, the driver does not

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-22 Thread Ondrej Zary
On Sunday 22 September 2013 18:49:42 Tejun Heo wrote: > Hello, Ondrej. > > On Fri, Sep 13, 2013 at 11:44:27PM +0200, Ondrej Zary wrote: > > This is caused by skipping ata_sff_softreset() when ap->ioaddr.ctl_addr > > is unset so ata_devchk() is never called. This patch seems to fix the > > problem

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-22 Thread Tejun Heo
Hello, Ondrej. On Fri, Sep 13, 2013 at 11:44:27PM +0200, Ondrej Zary wrote: > This is caused by skipping ata_sff_softreset() when ap->ioaddr.ctl_addr is > unset so ata_devchk() is never called. This patch seems to fix the problem. > Is it OK or can it cause more problems? > > --- a/drivers/ata/li

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-13 Thread Ondrej Zary
On Friday 13 September 2013 20:54:37 Ondrej Zary wrote: > On Thursday 12 September 2013 23:01:29 Ondrej Zary wrote: > > The test for 2nd I/O port validity is broken (reversed): > > On devices with no control port, the driver attempts to use invalid port > > 0, resulting in logs full of bad_io_acces

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-13 Thread Ondrej Zary
On Thursday 12 September 2013 23:01:29 Ondrej Zary wrote: > The test for 2nd I/O port validity is broken (reversed): > On devices with no control port, the driver attempts to use invalid port 0, > resulting in logs full of bad_io_access errors. > On devices with control port, the driver does not us

[PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-12 Thread Ondrej Zary
The test for 2nd I/O port validity is broken (reversed): On devices with no control port, the driver attempts to use invalid port 0, resulting in logs full of bad_io_access errors. On devices with control port, the driver does not use it. Signed-off-by: Ondrej Zary --- drivers/ata/pata_isapnp.c