Re: [PATCH] perf jevents: Fix suspicious code in fixregex()

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 10:38:35AM +0900, Namhyung Kim escreveu: > On Fri, Sep 4, 2020 at 3:41 AM Arnaldo Carvalho de Melo > wrote: > > Em Thu, Sep 03, 2020 at 10:47:39AM -0700, Ian Rogers escreveu: > > > On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim wrote: > > > > The new string should have enoug

Re: [PATCH] perf jevents: Fix suspicious code in fixregex()

2020-09-03 Thread Namhyung Kim
Hi Arnaldo and Ian, On Fri, Sep 4, 2020 at 3:41 AM Arnaldo Carvalho de Melo wrote: > > Em Thu, Sep 03, 2020 at 10:47:39AM -0700, Ian Rogers escreveu: > > On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim wrote: > > > The new string should have enough space for the original string and > > > the back sl

Re: [PATCH] perf jevents: Fix suspicious code in fixregex()

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 03, 2020 at 10:47:39AM -0700, Ian Rogers escreveu: > On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim wrote: > > The new string should have enough space for the original string and > > the back slashes IMHO. > > Cc: John Garry > > Cc: Kajol Jain > > Cc: Ian Rogers > > Signed-off-by: Nam

Re: [PATCH] perf jevents: Fix suspicious code in fixregex()

2020-09-03 Thread Ian Rogers
On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim wrote: > > The new string should have enough space for the original string and > the back slashes IMHO. > > Cc: John Garry > Cc: Kajol Jain > Cc: Ian Rogers > Signed-off-by: Namhyung Kim Reviewed-by: Ian Rogers Definitely looks like the right fix.

[PATCH] perf jevents: Fix suspicious code in fixregex()

2020-09-03 Thread Namhyung Kim
The new string should have enough space for the original string and the back slashes IMHO. Cc: John Garry Cc: Kajol Jain Cc: Ian Rogers Signed-off-by: Namhyung Kim --- tools/perf/pmu-events/jevents.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/pmu-events/jev