Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-19 Thread Tony Lindgren
* Matthijs van Duin [150319 04:20]: > On 17 March 2015 at 03:19, Tony Lindgren wrote: > > Yes so it seem here too, this is dm816x rev c, what do you have? > > jtag ID reads 0x1b81e02f, so that would be rev 1.1 / rev A. > > > Anyways, I'll add a note that at least rev c does not seems to do > >

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-19 Thread Matthijs van Duin
On 17 March 2015 at 03:19, Tony Lindgren wrote: > Yes so it seem here too, this is dm816x rev c, what do you have? jtag ID reads 0x1b81e02f, so that would be rev 1.1 / rev A. > Anyways, I'll add a note that at least rev c does not seems to do > anything with USB_CTRL but that we follow what the

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-16 Thread Tony Lindgren
* Matthijs van Duin [150316 14:17]: > *gets increasingly confused* :) > The datasheet (sprs614e) only contains register addresses, and they > seem to match the TRM's USB chapter. The only disagreement I can spot > is related to USB_CTRL register(s) in the control module (offsets > 0x620 and 0x

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-16 Thread Matthijs van Duin
*gets increasingly confused* The datasheet (sprs614e) only contains register addresses, and they seem to match the TRM's USB chapter. The only disagreement I can spot is related to USB_CTRL register(s) in the control module (offsets 0x620 and 0x628) where * the TRM claims both exist in the contro

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-16 Thread Tony Lindgren
* Matthijs van Duin [150314 14:04]: > On 13 March 2015 at 20:30, Tony Lindgren wrote: > > Hmm OK have to check that. It could also be that dm816x documentation > > is copy-paste from da850 or am3517 and the PHY got changed in the > > hardware as the registers don't match the documentation. Only t

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-14 Thread Matthijs van Duin
On 13 March 2015 at 20:30, Tony Lindgren wrote: > Hmm OK have to check that. It could also be that dm816x documentation > is copy-paste from da850 or am3517 and the PHY got changed in the > hardware as the registers don't match the documentation. Only the > dm816x errata has right documentation fo

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-13 Thread Tony Lindgren
* Matthijs van Duin [150313 11:39]: > Given that the documentation mentions the actual phy used, it may be > worth mentioning this also in the driver? i.e. that it's not a > "dm816x phy" but a "SR70LX Synopsys USB 2.0 OTG nanoPHY" (in contrast > to the dm814x and am335x which use a phy TI made th

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-13 Thread Matthijs van Duin
Given that the documentation mentions the actual phy used, it may be worth mentioning this also in the driver? i.e. that it's not a "dm816x phy" but a "SR70LX Synopsys USB 2.0 OTG nanoPHY" (in contrast to the dm814x and am335x which use a phy TI made themselves) USB is one of the few subsystems o

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-12 Thread Tony Lindgren
* Rusty Russell [150311 18:15]: > Tony Lindgren writes: > > * Paul Bolle [150311 04:16]: > > Oh, it should be just GPL v2 like most of the kernel. Probably copied > > the header from some other phy driver, will update that instead. > > Well, all my code is explicitly v2 or later. > > I'll leav

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-11 Thread Rusty Russell
Tony Lindgren writes: > * Paul Bolle [150311 04:16]: > Oh, it should be just GPL v2 like most of the kernel. Probably copied > the header from some other phy driver, will update that instead. Well, all my code is explicitly v2 or later. I'll leave it someone else to try to figure out the stats.

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-11 Thread Tony Lindgren
* Kishon Vijay Abraham I [150311 02:58]: > Hi Tony, > > On Tuesday 10 March 2015 02:21 AM, Tony Lindgren wrote: > >Add a minimal driver for dm816x USB. Otherwise we can just use > >the existing musb_am335x and musb_dsps on dm816x. > > If we can use an existing driver, I'd prefer that. Hmm that

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-11 Thread Tony Lindgren
* Paul Bolle [150311 04:16]: > On Mon, 2015-03-09 at 13:51 -0700, Tony Lindgren wrote: > > --- /dev/null > > +++ b/drivers/phy/phy-dm816x-usb.c > > @@ -0,0 +1,295 @@ > > +/* > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General P

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-11 Thread Paul Bolle
On Mon, 2015-03-09 at 13:51 -0700, Tony Lindgren wrote: > --- /dev/null > +++ b/drivers/phy/phy-dm816x-usb.c > @@ -0,0 +1,295 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-11 Thread Kishon Vijay Abraham I
Hi Tony, On Tuesday 10 March 2015 02:21 AM, Tony Lindgren wrote: Add a minimal driver for dm816x USB. Otherwise we can just use the existing musb_am335x and musb_dsps on dm816x. If we can use an existing driver, I'd prefer that. Cc: Brian Hutchinson Cc: Felipe Balbi Signed-off-by: Tony Lin

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-10 Thread Bin Liu
On Mon, Mar 9, 2015 at 4:41 PM, Tony Lindgren wrote: > * Bin Liu [150309 14:35]: >> On Mon, Mar 9, 2015 at 4:26 PM, Tony Lindgren wrote: >> > * Felipe Balbi [150309 14:21]: >> >> On Mon, Mar 09, 2015 at 04:17:29PM -0500, Bin Liu wrote: >> >> > On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Tony Lindgren
* Bin Liu [150309 14:35]: > On Mon, Mar 9, 2015 at 4:26 PM, Tony Lindgren wrote: > > * Felipe Balbi [150309 14:21]: > >> On Mon, Mar 09, 2015 at 04:17:29PM -0500, Bin Liu wrote: > >> > On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: > >> > > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Felipe Balbi
On Mon, Mar 09, 2015 at 04:17:29PM -0500, Bin Liu wrote: > On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: > > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: > >> Hi, > >> > >> On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: > >> > Add a minimal driver for dm816x USB. Otherwise

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Bin Liu
On Mon, Mar 9, 2015 at 4:20 PM, Tony Lindgren wrote: > * Bin Liu [150309 14:17]: >> On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: >> > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: >> >> Hi, >> >> >> >> On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: >> >> > Add a minimal

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Tony Lindgren
* Felipe Balbi [150309 14:21]: > On Mon, Mar 09, 2015 at 04:17:29PM -0500, Bin Liu wrote: > > On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: > > > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: > > >> Hi, > > >> > > >> On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: > > >> >

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Bin Liu
On Mon, Mar 9, 2015 at 4:26 PM, Tony Lindgren wrote: > * Felipe Balbi [150309 14:21]: >> On Mon, Mar 09, 2015 at 04:17:29PM -0500, Bin Liu wrote: >> > On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: >> > > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: >> > >> Hi, >> > >> >> > >> O

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Tony Lindgren
* Bin Liu [150309 14:17]: > On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: > > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: > >> Hi, > >> > >> On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: > >> > Add a minimal driver for dm816x USB. Otherwise we can just use > >> > the ex

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Bin Liu
On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: >> Hi, >> >> On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: >> > Add a minimal driver for dm816x USB. Otherwise we can just use >> > the existing musb_am335x and musb_dsps on dm816

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Felipe Balbi
On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: > Hi, > > On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: > > Add a minimal driver for dm816x USB. Otherwise we can just use > > the existing musb_am335x and musb_dsps on dm816x. > > dm816x has the almost identical usbss as that in am

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Bin Liu
Hi, On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: > Add a minimal driver for dm816x USB. Otherwise we can just use > the existing musb_am335x and musb_dsps on dm816x. dm816x has the almost identical usbss as that in am335x, we should be able to adopt musb_am335x and musb_dsps for dm816x,

[PATCH] phy: Add a driver for dm816x USB PHY

2015-03-09 Thread Tony Lindgren
Add a minimal driver for dm816x USB. Otherwise we can just use the existing musb_am335x and musb_dsps on dm816x. Cc: Brian Hutchinson Cc: Felipe Balbi Signed-off-by: Tony Lindgren --- /dev/null +++ b/Documentation/devicetree/bindings/phy/dm816x-phy.txt @@ -0,0 +1,24 @@ +Device tree binding doc