Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Laurent Pinchart
Hi Tobias, On Wed, Jul 01, 2020 at 04:07:09PM +0200, Tobias Klauser wrote: > On 2020-07-01 at 16:01:08 +0200, Laurent Pinchart > wrote: > > On Wed, Jul 01, 2020 at 04:00:26PM +0200, Tobias Klauser wrote: > >> On 2020-07-01 at 15:44:43 +0200, Laurent Pinchart > >> wrote: > >>> On Wed, Jul 01, 2

Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Tobias Klauser
On 2020-07-01 at 16:01:08 +0200, Laurent Pinchart wrote: > On Wed, Jul 01, 2020 at 04:00:26PM +0200, Tobias Klauser wrote: > > On 2020-07-01 at 15:44:43 +0200, Laurent Pinchart > > wrote: > > > On Wed, Jul 01, 2020 at 07:06:43PM +0530, Vinod Koul wrote: > > > > On 01-07-20, 16:19, Laurent Pinch

Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Laurent Pinchart
On Wed, Jul 01, 2020 at 04:00:26PM +0200, Tobias Klauser wrote: > On 2020-07-01 at 15:44:43 +0200, Laurent Pinchart > wrote: > > On Wed, Jul 01, 2020 at 07:06:43PM +0530, Vinod Koul wrote: > > > On 01-07-20, 16:19, Laurent Pinchart wrote: > > > > On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias K

Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Tobias Klauser
On 2020-07-01 at 15:44:43 +0200, Laurent Pinchart wrote: > On Wed, Jul 01, 2020 at 07:06:43PM +0530, Vinod Koul wrote: > > On 01-07-20, 16:19, Laurent Pinchart wrote: > > > On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias Klauser wrote: > > > > This fixes the following compiler warning when build

Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Vinod Koul
Hi Laurent, On 01-07-20, 16:44, Laurent Pinchart wrote: > > How about marking it as __maybe_unused instead? > > I don't mind either, I'll let Tobias decide, but his patch seems fine, > is there a drawback in his approach ? If it's just a matter of personal > preference, I'd rather not require a

Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Laurent Pinchart
Hi Vinod, On Wed, Jul 01, 2020 at 07:06:43PM +0530, Vinod Koul wrote: > On 01-07-20, 16:19, Laurent Pinchart wrote: > > On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias Klauser wrote: > > > This fixes the following compiler warning when building with > > > CONFIG_PM && !CONFIG_PM_SLEEP: > > > > >

Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Vinod Koul
On 01-07-20, 16:19, Laurent Pinchart wrote: > Hi Tobias, > > Thank you for the patch. > > On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias Klauser wrote: > > This fixes the following compiler warning when building with > > CONFIG_PM && !CONFIG_PM_SLEEP: > > > > drivers/phy/xilinx/phy-zynqmp.c:83

Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Laurent Pinchart
Hi Tobias, Thank you for the patch. On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias Klauser wrote: > This fixes the following compiler warning when building with > CONFIG_PM && !CONFIG_PM_SLEEP: > > drivers/phy/xilinx/phy-zynqmp.c:830:12: warning: ‘xpsgtr_resume’ defined but > not used [-Wunus

[PATCH] phy: zynqmp: Fix unused-function compiler warning

2020-07-01 Thread Tobias Klauser
This fixes the following compiler warning when building with CONFIG_PM && !CONFIG_PM_SLEEP: drivers/phy/xilinx/phy-zynqmp.c:830:12: warning: ‘xpsgtr_resume’ defined but not used [-Wunused-function] 830 | static int xpsgtr_resume(struct device *dev) |^ drivers/phy/x