Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-24 Thread Stephen Warren
On 06/21/2013 05:30 PM, Laurent Pinchart wrote: > Hi Stephen, > > On Friday 21 June 2013 13:06:47 Stephen Warren wrote: ... >> IIRC the idea of the PULL_PIN_DEFAULT was to avoid having to specify >> UP/DOWN for each pin/group, but could just say "default", which would >> then reduce the number of

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-24 Thread Heiko Stübner
Am Montag, 24. Juni 2013, 14:24:12 schrieb Linus Walleij: > On Sat, Jun 22, 2013 at 1:39 AM, Heiko Stübner wrote: > > Am Samstag, 22. Juni 2013, 01:30:18 schrieb Laurent Pinchart: > >> [Stephen] > >> > >> > IIRC the idea of the PULL_PIN_DEFAULT was to avoid having to specify > >> > UP/DOWN for ea

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-24 Thread Linus Walleij
On Sat, Jun 22, 2013 at 1:39 AM, Heiko Stübner wrote: > Am Samstag, 22. Juni 2013, 01:30:18 schrieb Laurent Pinchart: >> [Stephen] >> > IIRC the idea of the PULL_PIN_DEFAULT was to avoid having to specify >> > UP/DOWN for each pin/group, but could just say "default", which would >> > then reduce t

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-21 Thread Heiko Stübner
Am Samstag, 22. Juni 2013, 01:30:18 schrieb Laurent Pinchart: > Hi Stephen, > > On Friday 21 June 2013 13:06:47 Stephen Warren wrote: > > On 06/20/2013 06:38 AM, James Hogan wrote: > > > On 19/06/13 23:03, Stephen Warren wrote: > > >> On 06/16/2013 04:45 AM, Linus Walleij wrote: > > >>> From: Linu

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-21 Thread Laurent Pinchart
Hi Stephen, On Friday 21 June 2013 13:06:47 Stephen Warren wrote: > On 06/20/2013 06:38 AM, James Hogan wrote: > > On 19/06/13 23:03, Stephen Warren wrote: > >> On 06/16/2013 04:45 AM, Linus Walleij wrote: > >>> From: Linus Walleij > >>> > >>> It is counter-intuitive to have "0" mean disable in

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-21 Thread Stephen Warren
On 06/20/2013 06:38 AM, James Hogan wrote: > On 19/06/13 23:03, Stephen Warren wrote: >> On 06/16/2013 04:45 AM, Linus Walleij wrote: >>> From: Linus Walleij >>> >>> It is counter-intuitive to have "0" mean disable in a boolean >>> manner for electronic properties of pins such as pull-up and >>> p

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-20 Thread James Hogan
On 19/06/13 23:03, Stephen Warren wrote: > On 06/16/2013 04:45 AM, Linus Walleij wrote: >> From: Linus Walleij >> >> It is counter-intuitive to have "0" mean disable in a boolean >> manner for electronic properties of pins such as pull-up and >> pull-down. Therefore, define that a pull-up/pull-dow

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-19 Thread Stephen Warren
On 06/16/2013 04:45 AM, Linus Walleij wrote: > From: Linus Walleij > > It is counter-intuitive to have "0" mean disable in a boolean > manner for electronic properties of pins such as pull-up and > pull-down. Therefore, define that a pull-up/pull-down argument > of 0 to such a generic option mean

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-17 Thread Linus Walleij
On Mon, Jun 17, 2013 at 7:57 AM, Lothar Waßmann wrote: > Linus Walleij writes: >> - * if it is 0, pull-up is disabled. >> + * if it is 0, pull-up it total, i.e. the pin is connected to VDD. > ^^ > 'is'? Thanks for noticing, fixed this up when applying. Yours, Li

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-16 Thread Tony Prisk
On 16/06/13 22:45, Linus Walleij wrote: From: Linus Walleij It is counter-intuitive to have "0" mean disable in a boolean manner for electronic properties of pins such as pull-up and pull-down. Therefore, define that a pull-up/pull-down argument of 0 to such a generic option means that the pin

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-16 Thread Laurent Pinchart
Hi Linus, On Sunday 16 June 2013 12:45:48 Linus Walleij wrote: > From: Linus Walleij > > It is counter-intuitive to have "0" mean disable in a boolean > manner for electronic properties of pins such as pull-up and > pull-down. Therefore, define that a pull-up/pull-down argument > of 0 to such a

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-16 Thread Heiko Stübner
Am Sonntag, 16. Juni 2013, 12:45:48 schrieb Linus Walleij: > From: Linus Walleij > > It is counter-intuitive to have "0" mean disable in a boolean > manner for electronic properties of pins such as pull-up and > pull-down. Therefore, define that a pull-up/pull-down argument > of 0 to such a gener

[PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-16 Thread Linus Walleij
From: Linus Walleij It is counter-intuitive to have "0" mean disable in a boolean manner for electronic properties of pins such as pull-up and pull-down. Therefore, define that a pull-up/pull-down argument of 0 to such a generic option means that the pin is short-circuited to VDD or GROUND. Pull