Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-30 Thread Sergey Senozhatsky
Hi, On (20/11/30 14:09), Andreas Gruenbacher wrote: > > Sergey, what actual problem is your patch trying to solve? It sounds > like this is either theoretical and pointless, or you're trying to > build an external module that uses POSIX ACL functions that shouldn't > be needed when

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-30 Thread Andreas Gruenbacher
On Mon, Nov 30, 2020 at 2:09 PM Andreas Gruenbacher wrote: > Note that ext2 / ext4 could be built without POSIX ACL support in the > past. That's at least broken since the following two commits though: > > commit 59fed3bf8a461 ("ext2: cache NULL when both default_acl and > acl are NULL") >

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-30 Thread Andreas Gruenbacher
On Mon, Nov 30, 2020 at 5:29 AM Randy Dunlap wrote: > On 11/29/20 7:37 PM, Sergey Senozhatsky wrote: > > A quick question, shouldn't there be dummy definitions for > > the EXPORT_SYMBOL-s? So that external modules can be modprobed > > and used. > > > > Some of posix_acl exported symbols have

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-29 Thread kernel test robot
Hi Sergey, I love your patch! Perhaps something to improve: [auto build test WARNING on hch-configfs/for-next] [also build test WARNING on linux/master linus/master v5.10-rc6 next-20201127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-29 Thread Randy Dunlap
On 11/29/20 7:37 PM, Sergey Senozhatsky wrote: > A quick question, shouldn't there be dummy definitions for > the EXPORT_SYMBOL-s? So that external modules can be modprobed > and used. > > Some of posix_acl exported symbols have dummy definitions, > others don't. > > E.g. posix_acl_create() is

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-29 Thread Sergey Senozhatsky
A quick question, shouldn't there be dummy definitions for the EXPORT_SYMBOL-s? So that external modules can be modprobed and used. Some of posix_acl exported symbols have dummy definitions, others don't. E.g. posix_acl_create() is exported symbol and it's defined for both FS_POSIX_ACL and

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-29 Thread Sergey Senozhatsky
On (20/11/30 12:15), Sergey Senozhatsky wrote: > On (20/11/29 18:00), Randy Dunlap wrote: > > On 11/29/20 5:44 PM, Sergey Senozhatsky wrote: > > > Some functions that are declared when CONFIG_POSIX_ACL is defined > > > are not declared when CONFIG_POSIX_ACL is not defined. Add the > > > missing

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-29 Thread Sergey Senozhatsky
On (20/11/29 18:00), Randy Dunlap wrote: > On 11/29/20 5:44 PM, Sergey Senozhatsky wrote: > > Some functions that are declared when CONFIG_POSIX_ACL is defined > > are not declared when CONFIG_POSIX_ACL is not defined. Add the > > missing ones: > > set_posix_acl(), posix_acl_update_mode(),

Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-29 Thread Randy Dunlap
On 11/29/20 5:44 PM, Sergey Senozhatsky wrote: > Some functions that are declared when CONFIG_POSIX_ACL is defined > are not declared when CONFIG_POSIX_ACL is not defined. Add the > missing ones: > set_posix_acl(), posix_acl_update_mode(), get_cached_acl(), > get_cached_acl_rcu(),

[PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

2020-11-29 Thread Sergey Senozhatsky
Some functions that are declared when CONFIG_POSIX_ACL is defined are not declared when CONFIG_POSIX_ACL is not defined. Add the missing ones: set_posix_acl(), posix_acl_update_mode(), get_cached_acl(), get_cached_acl_rcu(), set_cached_acl(), forget_cached_acl(). Signed-off-by: Sergey