Re: [PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null

2015-10-11 Thread Colin Ian King
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/10/15 01:35, Daniel Axtens wrote: > > Hi Colin, > > This looks good. Out of curiousity, how did you find it? Code > inspection? Bug? Static analysis? static analysis with cppcheck. I forgot to mention that in the commit message. > > Not th

Re: [PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null

2015-10-11 Thread Daniel Axtens
Hi Colin, This looks good. Out of curiousity, how did you find it? Code inspection? Bug? Static analysis? Not that it's particularly meaningful for such a trivial fix, but FWIW: Reviewed-by: Daniel Axtens Regards, Daniel Colin King writes: > From: Colin Ian King > > pi_buff is being memse

[PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null

2015-10-08 Thread Colin King
From: Colin Ian King pi_buff is being memset before it is sanity checked. Move the memset after the null pi_buff sanity check to avoid an oops. Signed-off-by: Colin Ian King --- arch/powerpc/platforms/pseries/hvcserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/