Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-10 Thread Richard Pospesel
Ok I think this about covers it. The line length issues remain, but the script repors them as warnings so I'm not to worried about it. Patch follows: --- Input: BYD: Added proper touch support Implemented absolute position and touch reporting. Now BYD touchpads will use the synaptics/libinput

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-09 Thread Chris Diamand
Hi Richard, The patch applies! So your email client is working at last :) Looks good, just some style issues to fix now. > Updated BYD driver to report absolute coordinates and single-touch events. > init and gesture packet documentation. Confirmed working with both synaptics > and libinput

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-06 Thread Richard Pospesel
Updated BYD driver to report absolute coordinates and single-touch events. init and gesture packet documentation. Confirmed working with both synaptics and libinput xorg touchpad drivers. Patched against 98ee377144935857d8ad5d7d70cdab1da4ede32e on git://git.kernel.org/pub/scm/linux/kernel/g

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-06 Thread Richard Pospesel
Hy Chris, I'll send updated patch in a follow-up once I've verified thunderbird hasn't messed up the formatting yet again (seems like there are 3 separate settings I have to set, argh). On 02/05/2016 10:55 AM, Chris Diamand wrote: Hi Richard, Thanks for this. Rebased patch against 98ee37714

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-05 Thread Chris Diamand
Hi Richard, Thanks for this. > Rebased patch against 98ee377144935857d8ad5d7d70cdab1da4ede32e: Can you include a proper commit message and Signed-off-by line? > diff --git a/drivers/input/mouse/byd.c b/drivers/input/mouse/byd.c > index 9425e0f..f213a08 100644 > --- a/drivers/input/mouse/byd.c >

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-03 Thread Richard Pospesel
Rebased patch against 98ee377144935857d8ad5d7d70cdab1da4ede32e: --- diff --git a/drivers/input/mouse/byd.c b/drivers/input/mouse/byd.c index 9425e0f..f213a08 100644 --- a/drivers/input/mouse/byd.c +++ b/drivers/input/mouse/byd.c @@ -2,93 +2,276 @@ * BYD TouchPad PS/2 mouse driver * * Copyri

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-03 Thread Chris Diamand
> The Windows driver provides a visualization of the regions for the hardware > edge scrolling capability. When entering that screen, a particular command > pair is sent, and the touchpad starts sending interleaved REL and ABS > packets. When leaving that screen, another particular command pair is

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-03 Thread Richard Pospesel
Hi Chris, See inline: On 02/03/2016 12:58 AM, Chris Diamand wrote: Hi Richard, Reporting absolute position allows the synaptics and libinput xorg drivers to treat the BYD touchpad as a touchpad, rather than a mouse. This allows edge scrolling, tap to click, natural scrolling and any other lo

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-03 Thread Chris Diamand
Hi Richard, > Reporting absolute position allows the synaptics and libinput xorg drivers > to treat the BYD touchpad as a touchpad, rather than a mouse. This allows > edge scrolling, tap to click, natural scrolling and any other location > based single touch gesture to work. > > I opted to comple

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-02 Thread Richard Pospesel
New patch vs 98ee377144935857d8ad5d7d70cdab1da4ede32e on git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input follows. Confirmed builds and works as expected with that kernel branch. Signed-off-by: Richard Pospesel --- diff --git a/drivers/input/mouse/byd.c b/drivers/input/mouse/byd.c inde

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-02 Thread Richard Pospesel
Hi Chris, Reporting absolute position allows the synaptics and libinput xorg drivers to treat the BYD touchpad as a touchpad, rather than a mouse. This allows edge scrolling, tap to click, natural scrolling and any other location based single touch gesture to work. I opted to completely disable t

Re: [PATCH] psmouse: added BYD touchpad driver

2016-02-02 Thread Chris Diamand
Hi Richard, > This adds proper single-touch support for BYD touchpads to the psmouse input > driver. I posted a driver for the same touchpad a few weeks ago, which has been merged into linux-next. There's some stuff in this patch which is missing in my driver though, so we should definitely try a

[PATCH] psmouse: added BYD touchpad driver

2016-01-30 Thread Richard Pospesel
This adds proper single-touch support for BYD touchpads to the psmouse input driver. This patch is against commit b82dde0230439215b55e545880e90337ee16f51a (Merge tag 'please-pull-copy_file_range' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux ) of Linus' kernel branch. Signed-off-by: