Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-14 Thread Byungchul Park
On 2018-05-15 06:04, Paul E. McKenney wrote: On Mon, May 14, 2018 at 11:59:41AM +0900, Byungchul Park wrote: On 2018-05-12 오전 7:41, Joel Fernandes wrote: On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: Hello f

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-14 Thread Paul E. McKenney
On Mon, May 14, 2018 at 11:59:41AM +0900, Byungchul Park wrote: > On 2018-05-12 오전 7:41, Joel Fernandes wrote: > >On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: > >>On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: > >>>Hello folks, > >>> > >>>I think I wrote the ti

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-14 Thread Byungchul Park
On Mon, May 14, 2018 at 11:59 AM, Byungchul Park wrote: > > > On 2018-05-12 오전 7:41, Joel Fernandes wrote: >> >> On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: >>> >>> On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: Hello folks, I think I wrot

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-13 Thread Byungchul Park
On 2018-05-13 오전 2:26, Steven Rostedt wrote: On Sat, 12 May 2018 07:41:19 -0700 "Paul E. McKenney" wrote: Don't get me wrong, this discussion was quite useful to me. We probably need to at least change the comments, and perhaps the code as well. But I agree that we need input from Peter an

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-13 Thread Byungchul Park
On 2018-05-12 오전 7:41, Joel Fernandes wrote: On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: Hello folks, I think I wrote the title in a misleading way. Please change the title to something else such as, "rcu:

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-12 Thread Joel Fernandes
On Sat, May 12, 2018 at 07:41:19AM -0700, Paul E. McKenney wrote: > On Fri, May 11, 2018 at 11:30:37PM -0700, Joel Fernandes wrote: > > On Fri, May 11, 2018 at 10:08:24PM -0700, Paul E. McKenney wrote: > > > On Fri, May 11, 2018 at 03:41:38PM -0700, Joel Fernandes wrote: > > > > On Fri, May 11, 201

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-12 Thread Steven Rostedt
On Sat, 12 May 2018 07:41:19 -0700 "Paul E. McKenney" wrote: > Don't get me wrong, this discussion was quite useful to me. We probably > need to at least change the comments, and perhaps the code as well. But > I agree that we need input from Peter and Steven to make much more forward > progres

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-12 Thread Paul E. McKenney
On Fri, May 11, 2018 at 11:30:37PM -0700, Joel Fernandes wrote: > On Fri, May 11, 2018 at 10:08:24PM -0700, Paul E. McKenney wrote: > > On Fri, May 11, 2018 at 03:41:38PM -0700, Joel Fernandes wrote: > > > On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: > > > > On Fri, May 11, 201

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Joel Fernandes
On Fri, May 11, 2018 at 10:08:24PM -0700, Paul E. McKenney wrote: > On Fri, May 11, 2018 at 03:41:38PM -0700, Joel Fernandes wrote: > > On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: > > > On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: > > > > Hello folks, > > >

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Paul E. McKenney
On Fri, May 11, 2018 at 03:41:38PM -0700, Joel Fernandes wrote: > On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: > > On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: > > > Hello folks, > > > > > > I think I wrote the title in a misleading way. > > > > > > Please

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Joel Fernandes
On Fri, May 11, 2018 at 09:17:46AM -0700, Paul E. McKenney wrote: > On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: > > Hello folks, > > > > I think I wrote the title in a misleading way. > > > > Please change the title to something else such as, > > "rcu: Report a quiescent state

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Steven Rostedt
On Fri, 11 May 2018 10:27:35 -0700 "Paul E. McKenney" wrote: > On Fri, May 11, 2018 at 12:27:12PM -0400, Steven Rostedt wrote: > > On Fri, 11 May 2018 12:25:28 -0400 > > Steven Rostedt wrote: > > > > > I would also say that one should never call schedule() directly without > > > changing its

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Paul E. McKenney
On Fri, May 11, 2018 at 12:27:12PM -0400, Steven Rostedt wrote: > On Fri, 11 May 2018 12:25:28 -0400 > Steven Rostedt wrote: > > > I would also say that one should never call schedule() directly without > > changing its state to something other than TASK_RUNNING. Hence, calling > > schedule direc

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Steven Rostedt
On Fri, 11 May 2018 12:25:28 -0400 Steven Rostedt wrote: > I would also say that one should never call schedule() directly without > changing its state to something other than TASK_RUNNING. Hence, calling > schedule directly is saying you are ready to sleep. But that is not the > case with cond_r

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Steven Rostedt
On Fri, 11 May 2018 12:23:21 -0400 Steven Rostedt wrote: > On Fri, 11 May 2018 09:17:46 -0700 > "Paul E. McKenney" wrote: > > > > >index ee8cf5fc..7432261 100644 > > > >--- a/include/linux/rcupdate.h > > > >+++ b/include/linux/rcupdate.h > > > >@@ -195,8 +195,8 @@ static inline void exit_tasks_

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Steven Rostedt
On Fri, 11 May 2018 09:17:46 -0700 "Paul E. McKenney" wrote: > > >index ee8cf5fc..7432261 100644 > > >--- a/include/linux/rcupdate.h > > >+++ b/include/linux/rcupdate.h > > >@@ -195,8 +195,8 @@ static inline void exit_tasks_rcu_finish(void) { } > > > */ > > > #define cond_resched_tasks_rcu_qs(

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Paul E. McKenney
On Fri, May 11, 2018 at 09:57:54PM +0900, Byungchul Park wrote: > Hello folks, > > I think I wrote the title in a misleading way. > > Please change the title to something else such as, > "rcu: Report a quiescent state when it's in the state" or, > "rcu: Add points reporting quiescent states where

Re: [PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Byungchul Park
Hello folks, I think I wrote the title in a misleading way. Please change the title to something else such as, "rcu: Report a quiescent state when it's in the state" or, "rcu: Add points reporting quiescent states where proper" or so on. On 2018-05-11 오후 5:30, Byungchul Park wrote: We expect a

[PATCH] rcu: Report a quiescent state when it's exactly in the state

2018-05-11 Thread Byungchul Park
We expect a quiescent state of TASKS_RCU when cond_resched_tasks_rcu_qs() is called, no matter whether it actually be scheduled or not. However, it currently doesn't report the quiescent state when the task enters into __schedule() as it's called with preempt = true. So make it report the quiescent