Re: [PATCH] relay: use plain timer instead of delayed work

2007-05-06 Thread Satyam Sharma
On 5/7/07, Tom Zanussi <[EMAIL PROTECTED]> wrote: [...] Thanks for your comments - I've updated the patch to include timer.h but wait.h would still be needed for wait_queue_head_t, so will leave that in. Whoops ... I'd actually meant to say workqueue.h there, but perhaps must've got confused on

[PATCH] relay: use plain timer instead of delayed work

2007-05-06 Thread Tom Zanussi
Patch updated to include changes suggested by Oleg Nesterov and Satyam Sharma. --- relay doesn't need to use schedule_delayed_work() for waking readers when a simple timer will do. Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> --- include/linux/relay.h |3 ++- kernel/relay.c| 35

Re: [PATCH] relay: use plain timer instead of delayed work

2007-05-06 Thread Tom Zanussi
On Sun, 2007-05-06 at 15:40 +0530, Satyam Sharma wrote: > Hi Tom, > > On 5/6/07, Tom Zanussi <[EMAIL PROTECTED]> wrote: > > [...] > > relay doesn't need to use schedule_delayed_work() for waking readers > > when a simple timer will do. > > > > Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> > > [..

Re: [PATCH] relay: use plain timer instead of delayed work

2007-05-06 Thread Tom Zanussi
On Sun, 2007-05-06 at 16:47 +0400, Oleg Nesterov wrote: > On 05/05, Tom Zanussi wrote: > > > > This patch makes relay use timers instead of workqueues for reader > > waking. > > A couple of very minor nits, > > > @@ -337,11 +334,11 @@ static void __relay_reset(struct rchan_buf *buf, > > unsigned

Re: [PATCH] relay: use plain timer instead of delayed work

2007-05-06 Thread Oleg Nesterov
On 05/05, Tom Zanussi wrote: > > This patch makes relay use timers instead of workqueues for reader > waking. A couple of very minor nits, > @@ -337,11 +334,11 @@ static void __relay_reset(struct rchan_buf *buf, > unsigned int init) > if (init) { > init_waitqueue_head(&buf->r

Re: [PATCH] relay: use plain timer instead of delayed work

2007-05-06 Thread Satyam Sharma
Hi Tom, On 5/6/07, Tom Zanussi <[EMAIL PROTECTED]> wrote: [...] relay doesn't need to use schedule_delayed_work() for waking readers when a simple timer will do. Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> [...] diff --git a/include/linux/relay.h b/include/linux/relay.h index 759a0f9..cac073

[PATCH] relay: use plain timer instead of delayed work

2007-05-05 Thread Tom Zanussi
Hi, This patch makes relay use timers instead of workqueues for reader waking. Tom --- relay doesn't need to use schedule_delayed_work() for waking readers when a simple timer will do. Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> --- include/linux/relay.h |2 +- kernel/relay.c|