Re: [PATCH] rtc: rtc-max8925: remove redundant check on ret

2017-07-30 Thread Alexandre Belloni
On 07/06/2017 at 16:26:15 +0100, Colin King wrote: > From: Colin Ian King > > The check on ret < 0 is redundant as the goto destination is the > next statment. Remove this redudant check and goto. > > Detected by CoverityScan, CID#1268785 ("Identical code for different > branches") > > Signed-

Re: [PATCH] rtc: rtc-max8925: remove redundant check on ret

2017-06-07 Thread Andy Shevchenko
On Wed, Jun 7, 2017 at 6:26 PM, Colin King wrote: > From: Colin Ian King > > The check on ret < 0 is redundant as the goto destination is the > next statment. Remove this redudant check and goto. > > Detected by CoverityScan, CID#1268785 ("Identical code for different > branches") >

[PATCH] rtc: rtc-max8925: remove redundant check on ret

2017-06-07 Thread Colin King
From: Colin Ian King The check on ret < 0 is redundant as the goto destination is the next statment. Remove this redudant check and goto. Detected by CoverityScan, CID#1268785 ("Identical code for different branches") Signed-off-by: Colin Ian King --- drivers/rtc/rtc-max8925.c | 2 -- 1 file